Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965656AbaFQQhn (ORCPT ); Tue, 17 Jun 2014 12:37:43 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:41202 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965349AbaFQQhj (ORCPT ); Tue, 17 Jun 2014 12:37:39 -0400 Date: Tue, 17 Jun 2014 17:37:21 +0100 From: Lee Jones To: Keerthy Cc: linux-omap@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org, linux-kernel@vger.kernel.org, sameo@linux.intel.com Subject: Re: [PATCH 7/9] regulator: palmas: Add palmas_pmic_driver_data structure Message-ID: <20140617163721.GR29841@lee--X1> References: <1401272423-25761-1-git-send-email-j-keerthy@ti.com> <1401272423-25761-8-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1401272423-25761-8-git-send-email-j-keerthy@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 May 2014, Keerthy wrote: > Add palmas_pmic_driver_data structure. > > Signed-off-by: Keerthy > --- > include/linux/mfd/palmas.h | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h > index 8d68452..70f0695 100644 > --- a/include/linux/mfd/palmas.h > +++ b/include/linux/mfd/palmas.h > @@ -53,6 +53,8 @@ struct palmas_pmic; > struct palmas_gpadc; > struct palmas_resource; > struct palmas_usb; > +struct palmas_pmic_driver_data; > +struct palmas_pmic_platform_data; > > enum palmas_usb_state { > PALMAS_USB_STATE_DISCONNECT, > @@ -76,6 +78,8 @@ struct palmas { > struct mutex irq_lock; > struct regmap_irq_chip_data *irq_data; > > + struct palmas_pmic_driver_data *pmic_ddata; > + > /* Child Devices */ > struct palmas_pmic *pmic; > struct palmas_gpadc *gpadc; > @@ -107,6 +111,27 @@ struct regs_info { > int sleep_id; > }; > > +struct palmas_pmic_driver_data { > + int smps_start; > + int smps_end; > + int ldo_begin; > + int ldo_end; > + int max_reg; > + struct regs_info *palmas_regs_info; > + struct of_regulator_match *palmas_matches; > + struct palmas_sleep_requestor_info *sleep_req_info; > + int (*smps_register)(struct palmas_pmic *pmic, > + struct palmas_pmic_driver_data *ddata, > + struct palmas_pmic_platform_data *pdata, > + const char *pdev_name, > + struct regulator_config config); > + int (*ldo_register)(struct palmas_pmic *pmic, > + struct palmas_pmic_driver_data *ddata, > + struct palmas_pmic_platform_data *pdata, > + const char *pdev_name, > + struct regulator_config config); Are you sure you need to store all of this stuff? Particularly the match pointer. Do you really re-use it? > +}; > + > struct palmas_gpadc_platform_data { > /* Channel 3 current source is only enabled during conversion */ > int ch3_current; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/