Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965883AbaFQQy4 (ORCPT ); Tue, 17 Jun 2014 12:54:56 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:50000 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965868AbaFQQyy (ORCPT ); Tue, 17 Jun 2014 12:54:54 -0400 Message-ID: <1403024089.1995.0.camel@jarvis> Subject: Re: [PATCH 01/24] kobject: return actual error on kset_create_and_add From: James Bottomley To: Christoph Lameter Cc: Greg KH , Jeff Liu , Andrew Morton , Pekka Enberg , Matt Mackall , benh@kernel.crashing.org, paulus@samba.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, herbert@gondor.apana.org.au, davem@davemloft.net, stefanr@s5r6.in-berlin.de, joro@8bytes.org, jejb@parisc-linux.org, deller@gmx.de, bhelgaas@google.com, clm@fb.com, Josef Bacik , swhiteho@redhat.com, bharrosh@panasas.com, bhalevy@primarydata.com, ccaulfie@redhat.com, teigland@redhat.com, "Theodore Ts'o" , adilger.kernel@dilger.ca, jaegeuk@kernel.org, cm224.lee@samsung.com, Mark Fasheh , Joel Becker , casey@schaufler-ca.com, LKML Date: Tue, 17 Jun 2014 09:54:49 -0700 In-Reply-To: References: <53A04FF7.5050900@oracle.com> <20140617154730.GA14153@kroah.com> <1403021389.27991.11.camel@dabdike.int.hansenpartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-06-17 at 11:29 -0500, Christoph Lameter wrote: > On Tue, 17 Jun 2014, James Bottomley wrote: > > > What useful information does this supply? The current assumption on > > NULL return is -ENOMEM ... what's the interesting case where this > > assumption is wrong? > > No idea. Sysfs just ignored all error codes and returns NULL right now. > If it is indeed just ENOMEN then we have no issue. Well, I think when we have that justification, then we can decide on the merits of the patch set. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/