Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964925AbaFQUU1 (ORCPT ); Tue, 17 Jun 2014 16:20:27 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:56520 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932927AbaFQUU0 (ORCPT ); Tue, 17 Jun 2014 16:20:26 -0400 Date: Tue, 17 Jun 2014 13:20:24 -0700 (PDT) Message-Id: <20140617.132024.1213369771856463527.davem@davemloft.net> To: isubramanian@apm.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jcm@redhat.com, patches@apm.com, rapatel@apm.com, kchudgar@apm.com Subject: Re: [PATCH v6 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support. From: David Miller In-Reply-To: References: <1402964326-11147-5-git-send-email-isubramanian@apm.com> <20140616.214247.1154200670003936158.davem@davemloft.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 17 Jun 2014 13:20:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Iyappan Subramanian Date: Tue, 17 Jun 2014 12:21:08 -0700 > On Mon, Jun 16, 2014 at 9:42 PM, David Miller wrote: >> From: Iyappan Subramanian >> Date: Mon, 16 Jun 2014 17:18:46 -0700 >> >>> +static netdev_tx_t xgene_enet_start_xmit(struct sk_buff *skb, >>> + struct net_device *ndev) >>> +{ >>> + struct xgene_enet_pdata *pdata = netdev_priv(ndev); >>> + struct xgene_enet_desc_ring *tx_ring = pdata->tx_ring; >>> + struct xgene_enet_desc_ring *cp_ring = tx_ring->cp_ring; >>> + u32 tx_level, cq_level; >>> + >>> + tx_level = xgene_enet_ring_len(tx_ring); >>> + cq_level = xgene_enet_ring_len(cp_ring); >>> + if (unlikely(tx_level > pdata->tx_qcnt_hi || >>> + cq_level > pdata->cp_qcnt_hi)) { >>> + netif_stop_queue(ndev); >>> + return NETDEV_TX_BUSY; >>> + } >>> + >>> + if (xgene_enet_setup_tx_desc(tx_ring, skb)) >>> + return NETDEV_TX_OK; >> >> If you return NETDEV_TX_OK, it is your responsibility to deal with the >> SKB, because you own it. >> >> In particular, you have to free the packet. > > skb freeing happens in xgene_enet_tx_completion(). You're not queueing up the packet when DMA mapping the packet fails, which is the only condition that causes xgene_enet_setup_tx_desc() to return an error, so xgene_enet_tx_completion() will not be called. Can you really not see this? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/