Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756040AbaFRAJI (ORCPT ); Tue, 17 Jun 2014 20:09:08 -0400 Received: from mail-ig0-f176.google.com ([209.85.213.176]:48233 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753186AbaFRAJF (ORCPT ); Tue, 17 Jun 2014 20:09:05 -0400 MIME-Version: 1.0 In-Reply-To: <1402426287-31157-1-git-send-email-m-karicheri2@ti.com> References: <1402426287-31157-1-git-send-email-m-karicheri2@ti.com> From: Bjorn Helgaas Date: Tue, 17 Jun 2014 18:08:43 -0600 Message-ID: Subject: Re: [PATCH v2 0/8] Add Keystone PCIe controller driver To: Murali Karicheri Cc: linux-arm , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , Santosh Shilimkar , Russell King , Grant Likely , Rob Herring , Mohit Kumar , Jingoo Han , Pratyush Anand , Richard Zhu , Kishon Vijay Abraham I , Marek Vasut , Arnd Bergmann , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 10, 2014 at 02:51:19PM -0400, Murali Karicheri wrote: > This patch adds a PCIe controller driver for Keystone SoCs. This > is based on v1 of the series posted to the mailing list. > > CC: Santosh Shilimkar > CC: Russell King > CC: Grant Likely > CC: Rob Herring > CC: Mohit Kumar > CC: Jingoo Han > CC: Bjorn Helgaas > CC: Pratyush Anand > CC: Richard Zhu > CC: Kishon Vijay Abraham I > CC: Marek Vasut > CC: Arnd Bergmann > CC: Pawel Moll > CC: Mark Rutland > CC: Ian Campbell > CC: Kumar Gala > CC: Randy Dunlap > CC: Grant Likely > > > Changelog: > > V2 > - Split the designware pcie enhancement patch to multiple > patches based on functionality added > - Remove the quirk code and add a patch to fix mps/mrss > tuning for ARM. Use kernel command line parameter > pci=pcie_bus_perf to work with Keystone PCI Controller. > Following patch addressed this. > [PATCH v1] ARM: pci: add call to pcie_bus_configure_settings() > - Add documentation for device tree bindings > - Add separate interrupt controller nodes for MSI and Legacy > IRQs and use irq map for legacy IRQ > - Use compatibility to identify v3.65 version of the DW hardware > and use it to customize the designware common code. > - Use reg property for configuration space instead of range > - Other minor updates based on code inspection. > > V1 > - Add an interrupt controller node for Legacy irq chip and use > interrupt map/map-mask property to map legacy IRQs A/B/C/D > - Add a Phy driver to replace the original serdes driver > - Move common application register handling code to a separate > file to allow re-use across other platforms that use older > DW PCIe h/w > - PCI quirk for maximum read request size. Check and override only > if the maximum is higher than what controller can handle. > - Converted to a module platform driver. > > > Murali Karicheri (8): > PCI: designware: add rd[wr]_other_conf API > PCI: designware: refactor host init code to re-use on v3.65 DW pci hw > PCI: designware: update pcie core driver to work with dw hw version > 3.65 > PCI: designware: add msi controller functions for v3.65 hw > PCI: designware: add PCI controller functions for v3.65 DW hw > phy: Add serdes phy driver for keystone > PCI: keystone: add pcie driver based on designware core driver > ARM: keystone: add pcie related options > > .../devicetree/bindings/pci/designware-pcie.txt | 42 ++ > .../devicetree/bindings/pci/pci-keystone.txt | 56 +++ > .../bindings/phy/phy-keystone-serdes.txt | 25 ++ > arch/arm/mach-keystone/Kconfig | 1 + > drivers/pci/host/Kconfig | 12 + > drivers/pci/host/Makefile | 2 + > drivers/pci/host/pci-dw-v3_65-msi.c | 149 +++++++ > drivers/pci/host/pci-dw-v3_65.c | 390 ++++++++++++++++++ > drivers/pci/host/pci-dw-v3_65.h | 34 ++ > drivers/pci/host/pci-keystone.c | 418 ++++++++++++++++++++ > drivers/pci/host/pcie-designware.c | 175 +++++--- > drivers/pci/host/pcie-designware.h | 42 +- > drivers/phy/Kconfig | 6 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-keystone-serdes.c | 230 +++++++++++ > 15 files changed, 1531 insertions(+), 52 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pci/pci-keystone.txt > create mode 100644 Documentation/devicetree/bindings/phy/phy-keystone-serdes.txt > create mode 100644 drivers/pci/host/pci-dw-v3_65-msi.c > create mode 100644 drivers/pci/host/pci-dw-v3_65.c > create mode 100644 drivers/pci/host/pci-dw-v3_65.h > create mode 100644 drivers/pci/host/pci-keystone.c > create mode 100644 drivers/phy/phy-keystone-serdes.c I'm not willing to merge phy-keystone-serdes.c because I don't maintain drivers/phy and because of the binary blob of register values it contains, but maybe somebody else will. I assume it could be merged by itself before the rest of this. I'm looking for acks from Mohit and/or Jingoo for the pci/host changes, and from Arnd for the devicetree/bindings changes. Adding these "-dw-3_64" files is sort of ugly. If that code is only used by keystone, maybe it could just be moved to pci-keystone.c? But I'll defer to Mohit and Jingoo on that and the way you modify pcie-designware.c. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/