Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756583AbaFREyH (ORCPT ); Wed, 18 Jun 2014 00:54:07 -0400 Received: from mail-ve0-f169.google.com ([209.85.128.169]:65126 "EHLO mail-ve0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498AbaFREyF (ORCPT ); Wed, 18 Jun 2014 00:54:05 -0400 MIME-Version: 1.0 In-Reply-To: References: <1402954800-28215-1-git-send-email-dianders@chromium.org> <1402954800-28215-11-git-send-email-dianders@chromium.org> Date: Tue, 17 Jun 2014 21:54:03 -0700 X-Google-Sender-Auth: LRqp4Mmzaf7BHvxQrZUMAfr7f1U Message-ID: Subject: Re: [PATCH 10/10] mfd: cros_ec: ec_dev->cmd_xfer() returns number of bytes received from EC From: Doug Anderson To: Simon Glass Cc: Lee Jones , Andrew Bresticker , Stephen Warren , Olof Johansson , Sonny Rao , linux-samsung-soc , Javier Martinez Canillas , Bill Richardson , Wolfram Sang , Mark Brown , Samuel Ortiz , Vincent Palatin , "linux-i2c@vger.kernel.org" , lk Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simon, On Tue, Jun 17, 2014 at 8:46 PM, Simon Glass wrote: > Hi, > > On 16 June 2014 14:40, Doug Anderson wrote: >> From: Bill Richardson >> >> When communicating with the EC, the cmd_xfer() function should return the >> number of bytes it received from the EC, or negative on error. > > This is just for the I2C tunnel feature, right? If so, I think this > should be mentioned here. It seems to be affecting ec_i2c_xfer(), not > cmd_xfer(). No, the tunnel feature is implemented just fine without this (and is already landed and working). It looks like the (not yet upstreamed) ec_i2c_limited_xfer for spring returns this new value directly but I'm not convinced that's technicall correct. Bill can correct me if I'm wrong, but I think this is primarily interesting once we add in cros_ec_dev (the userspace API) which needs this info. Until that happens this patch doesn't hurt and just returns some extra info. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/