Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933950AbaFRGui (ORCPT ); Wed, 18 Jun 2014 02:50:38 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:50766 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1756579AbaFRGuh (ORCPT ); Wed, 18 Jun 2014 02:50:37 -0400 X-IronPort-AV: E=Sophos;i="5.00,730,1396972800"; d="scan'208";a="32074464" Message-ID: <53A136C4.5070206@cn.fujitsu.com> Date: Wed, 18 Jun 2014 14:50:44 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Gleb Natapov CC: , , , , , , , , , , , , , Tang Chen Subject: Re: [RFC PATCH 1/1] Move two pinned pages to non-movable node in kvm. References: <1403070600-6083-1-git-send-email-tangchen@cn.fujitsu.com> <20140618061230.GA10948@minantech.com> In-Reply-To: <20140618061230.GA10948@minantech.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.99] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gleb, Thanks for the quick reply. Please see below. On 06/18/2014 02:12 PM, Gleb Natapov wrote: > On Wed, Jun 18, 2014 at 01:50:00PM +0800, Tang Chen wrote: >> [Questions] >> And by the way, would you guys please answer the following questions for me ? >> >> 1. What's the ept identity pagetable for ? Only one page is enough ? >> >> 2. Is the ept identity pagetable only used in realmode ? >> Can we free it once the guest is up (vcpu in protect mode)? >> >> 3. Now, ept identity pagetable is allocated in qemu userspace. >> Can we allocate it in kernel space ? > What would be the benefit? I think the benefit is we can hot-remove the host memory a kvm guest is using. For now, only memory in ZONE_MOVABLE can be migrated/hot-removed. And the kernel will never use ZONE_MOVABLE memory. So if we can allocate these two pages in kernel space, we can pin them without any trouble. When doing memory hot-remove, the kernel will not try to migrate these two pages. > >> >> 4. If I want to migrate these two pages, what do you think is the best way ? >> > I answered most of those here: http://www.mail-archive.com/kvm@vger.kernel.org/msg103718.html I'm sorry I must missed this email. Seeing your advice, we can unpin these two pages and repin them in the next EPT violation. So about this problem, which solution would you prefer, allocate these two pages in kernel space, or migrate them before memory hot-remove ? I think the first solution is simpler. But I'm not quite sure if there is any other pages pinned in memory. If we have the same problem with other kvm pages, I think it is better to solve it in the second way. What do you think ? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/