Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933870AbaFRHq7 (ORCPT ); Wed, 18 Jun 2014 03:46:59 -0400 Received: from mail-ig0-f176.google.com ([209.85.213.176]:37789 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933242AbaFRHq6 (ORCPT ); Wed, 18 Jun 2014 03:46:58 -0400 Date: Wed, 18 Jun 2014 08:46:52 +0100 From: Lee Jones To: Doug Anderson Cc: Andrew Bresticker , swarren@wwwdotorg.org, olof@lixom.net, Sonny Rao , linux-samsung-soc@vger.kernel.org, Javier Martinez Canillas , Bill Richardson , sjg@chromium.org, Wolfram Sang , broonie@kernel.org, sameo@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/10] mdf: cros_ec: Detect in-progress commands Message-ID: <20140618074652.GG21030@lee--X1> References: <1402954800-28215-1-git-send-email-dianders@chromium.org> <1402954800-28215-6-git-send-email-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1402954800-28215-6-git-send-email-dianders@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Jun 2014, Doug Anderson wrote: > From: Simon Glass > > Some commands take a while to execute. Use -EAGAIN to signal this to the > caller. > > Signed-off-by: Simon Glass > Signed-off-by: Doug Anderson > --- > drivers/mfd/cros_ec_spi.c | 6 ++++++ > 1 file changed, 6 insertions(+) For the re-spin: Acked-by: Lee Jones > diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c > index 52d4d7b..c29a2d7 100644 > --- a/drivers/mfd/cros_ec_spi.c > +++ b/drivers/mfd/cros_ec_spi.c > @@ -292,6 +292,12 @@ static int cros_ec_cmd_xfer_spi(struct cros_ec_device *ec_dev, > /* check response error code */ > ptr = ec_dev->din; > if (ptr[0]) { > + if (ptr[0] == EC_RES_IN_PROGRESS) { > + dev_dbg(ec_dev->dev, "command 0x%02x in progress\n", > + ec_msg->cmd); > + ret = -EAGAIN; > + goto exit; > + } > dev_warn(ec_dev->dev, "command 0x%02x returned an error %d\n", > ec_msg->cmd, ptr[0]); > debug_packet(ec_dev->dev, "in_err", ptr, len); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/