Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934139AbaFRH7j (ORCPT ); Wed, 18 Jun 2014 03:59:39 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:45366 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933133AbaFRH7i (ORCPT ); Wed, 18 Jun 2014 03:59:38 -0400 MIME-Version: 1.0 In-Reply-To: <1403033788-8315-1-git-send-email-fabf@skynet.be> References: <1403033788-8315-1-git-send-email-fabf@skynet.be> Date: Wed, 18 Jun 2014 09:59:37 +0200 Message-ID: Subject: Re: [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree From: Helmut Schaa To: Fabian Frederick Cc: LKML , Ivo van Doorn Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Jun 17, 2014 at 9:36 PM, Fabian Frederick wrote: > Fix checkpatch warning: > WARNING: kfree(NULL) is safe this check is probably not required Thanks Fabian. This should go through the wireless tree I guess, mind to send to linux-wireless@vger.kernel.org? Helmut > Cc: Ivo van Doorn > Cc: Helmut Schaa > Signed-off-by: Fabian Frederick > --- > drivers/net/wireless/rt2x00/rt2x00dev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c > index 2bde672..c2c2300 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00dev.c > +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c > @@ -1452,8 +1452,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev) > /* > * Free the driver data. > */ > - if (rt2x00dev->drv_data) > - kfree(rt2x00dev->drv_data); > + kfree(rt2x00dev->drv_data); > } > EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev); > > -- > 1.8.4.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/