Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965250AbaFRJFw (ORCPT ); Wed, 18 Jun 2014 05:05:52 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:45536 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964813AbaFRJFt (ORCPT ); Wed, 18 Jun 2014 05:05:49 -0400 Date: Wed, 18 Jun 2014 10:05:00 +0100 From: Mark Rutland To: Varka Bhadram Cc: "netdev@vger.kernel.org" , "alex.bluesman.smirnov@gmail.com" , "dbaryshkov@gmail.com" , "linux-zigbee-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" , "devicetree@vger.kernel.org" , Varka Bhadram Subject: Re: [PATCH net-next v2 3/3] devicetree: add devicetree bindings for cc2520 driver Message-ID: <20140618090500.GA26461@leverpostej> References: <1403068565-32224-1-git-send-email-varkab@cdac.in> <1403068565-32224-4-git-send-email-varkab@cdac.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403068565-32224-4-git-send-email-varkab@cdac.in> Thread-Topic: [PATCH net-next v2 3/3] devicetree: add devicetree bindings for cc2520 driver Accept-Language: en-GB, en-US Content-Language: en-US User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 18, 2014 at 06:16:05AM +0100, Varka Bhadram wrote: > devicetree bindings for cc2520 radio driver. > > Signed-off-by: Varka Bhadram > --- > .../devicetree/bindings/net/ieee802154/cc2520.txt | 26 ++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ieee802154/cc2520.txt > > diff --git a/Documentation/devicetree/bindings/net/ieee802154/cc2520.txt b/Documentation/devicetree/bindings/net/ieee802154/cc2520.txt > new file mode 100644 > index 0000000..f0a749d > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/ieee802154/cc2520.txt > @@ -0,0 +1,26 @@ > +CC2520 IEEE 802.15.4 Compatible Radio > + > +Required properties: > + - compatible: should be "ti,cc2520" > + - spi-max-frequency: maximal bus speed (8000000), should be set to 4000000 depends > + sync or async operation mode > + - reg: the chipselect index > + - mode: SPI mode What exactly is this property? It doesn't seem to be used by the driver, the example is opaque, and this doesn't seem to match any existing bindings (a grep for "mode" in Documentation/devicetree/bindings/spi only found me a string "mode" property). The example has several properties (the GPIOs and pinctrl) not listed here... Mark. > +Example: > + > + cc2520@0 { > + compatible = "ti,cc2520"; > + reg = <0>; > + spi-max-frequency = <4000000>; > + mode = <1>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&cc2520_cape_pins>; /*GPIO pin muxing details*/ > + > + fifo-gpio = <&gpio1 18 0>; > + fifop-gpio = <&gpio1 19 0>; > + sfd-gpio = <&gpio1 13 0>; > + cca-gpio = <&gpio1 16 0>; > + vreg-gpio = <&gpio0 31 0>; > + reset-gpio = <&gpio1 12 0>; > + }; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/