Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965865AbaFRKQI (ORCPT ); Wed, 18 Jun 2014 06:16:08 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:52156 "EHLO mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965123AbaFRKQF convert rfc822-to-8bit (ORCPT ); Wed, 18 Jun 2014 06:16:05 -0400 From: Mohit KUMAR DCG To: Murali Karicheri , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , Pratyush ANAND Cc: Santosh Shilimkar , Russell King , Grant Likely , Rob Herring , Jingoo Han , Bjorn Helgaas , Richard Zhu , Kishon Vijay Abraham I , Marek Vasut , Arnd Bergmann , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap Date: Wed, 18 Jun 2014 18:14:28 +0800 Subject: RE: [PATCH v2 0/8] Add Keystone PCIe controller driver Thread-Topic: [PATCH v2 0/8] Add Keystone PCIe controller driver Thread-Index: Ac+E3Sskd0J36VlqT7KlUC+syPQvVgF/e5fQ Message-ID: <2CC2A0A4A178534D93D5159BF3BCB6619C5F8169D1@EAPEX1MAIL1.st.com> References: <1402426287-31157-1-git-send-email-m-karicheri2@ti.com> In-Reply-To: <1402426287-31157-1-git-send-email-m-karicheri2@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.12.52,1.0.14,0.0.0000 definitions=2014-06-18_04:2014-06-17,2014-06-18,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Murali, > -----Original Message----- > From: Murali Karicheri [mailto:m-karicheri2@ti.com] > Sent: Wednesday, June 11, 2014 12:21 AM > To: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux- > doc@vger.kernel.org > Cc: Murali Karicheri; Santosh Shilimkar; Russell King; Grant Likely; Rob Herring; > Mohit KUMAR DCG; Jingoo Han; Bjorn Helgaas; Pratyush ANAND; Richard > Zhu; Kishon Vijay Abraham I; Marek Vasut; Arnd Bergmann; Pawel Moll; > Mark Rutland; Ian Campbell; Kumar Gala; Randy Dunlap > Subject: [PATCH v2 0/8] Add Keystone PCIe controller driver > > This patch adds a PCIe controller driver for Keystone SoCs. This is based on v1 > of the series posted to the mailing list. > 1. I think your first patch is OK which handles platform specific ATU implementation. 2. For MSI part, I think you just need to add two new callbacks with pp-ops, something similar to: pp->ops->msi_set pp->ops->msi_clear With these two platform specific callbacks you should be able to manage MSI handling. So idea is that dw_msi code uses pp->ops->msi_set/clear if platform define these, otherwise use dw_msi_set/clear (which you need to refactor from existing code) So other than your keystone changes we expect 3 patches: -- 1st same as you sent 1/8: for ATU handeling -- 2nd to refactor dw_msi_set/clear: refactor from existing code -- 3rd to use pp->ops->msi_set/clear if defined. Pls let us know for any issue or have different opinion. Regards Mohit > > -- > 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/