Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966426AbaFRMSM (ORCPT ); Wed, 18 Jun 2014 08:18:12 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:1063 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966162AbaFRMSK (ORCPT ); Wed, 18 Jun 2014 08:18:10 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 18 Jun 2014 05:12:29 -0700 Date: Wed, 18 Jun 2014 15:18:06 +0300 From: Peter De Schrijver To: Thierry Reding CC: Stephen Warren , Mikko Perttunen , "tj@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-ide@vger.kernel.org" Subject: Re: [PATCH 6/9] ARM: tegra: Export tegra_powergate_power_on Message-ID: <20140618121806.GJ3407@tbergstrom-lnx.Nvidia.com> References: <1401881559-18469-1-git-send-email-mperttunen@nvidia.com> <1401881559-18469-7-git-send-email-mperttunen@nvidia.com> <539F691E.5030204@wwwdotorg.org> <20140617121313.GE18816@ulmo> <20140617140146.GH3407@tbergstrom-lnx.Nvidia.com> <20140617215119.GC24743@mithrandir> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20140617215119.GC24743@mithrandir> X-NVConfidentiality: public User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 17, 2014 at 11:51:20PM +0200, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Jun 17, 2014 at 05:01:46PM +0300, Peter De Schrijver wrote: > > On Tue, Jun 17, 2014 at 02:13:15PM +0200, Thierry Reding wrote: > > > > Old Signed by an unknown key > > > > > > On Mon, Jun 16, 2014 at 04:01:02PM -0600, Stephen Warren wrote: > > > > On 06/04/2014 05:32 AM, Mikko Perttunen wrote: > > > > > This symbol needs to be exported to power on rails without using > > > > > tegra_powergate_sequence_power_up. tegra_powergate_sequence_power_up > > > > > cannot be used in situations where the driver wants to handle clocking > > > > > by itself. > > > > > > > > Thierry, are you OK with this change? > > > > > > I would've preferred tegra_powergate_sequence_power_up() to be used > > > > I don't think the current tegra_powergate_sequence_power_up() API is very well > > defined though. I don't think the clocks and resets required by the sequence > > should be provided by the driver. For one, there can be several clocks and > > resets that need to be controlled for a single domain. > > Do you have any suggestions for what the API should look like? Even if > we plan to move to some different API, I think there's some advantage in > using it consistently if for no other reason than to make it easier to > replace occurrences later on. > I think the API should only have the domain ID as input so: int tegra_powerdomain_on(int id) /* * Prerequisites: domain is off * Result: domain is on, clocks of the modules in the domain are off, modules are in reset */ int tegra_powerdomain_off(int id) /* * Prerequisites: all clocks of the modules in the domain are off * result: domain is off */ Cheers, Peter/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/