Date: Wed, 18 Jun 2014 08:20:30 -0400
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: relative objtree change broke tar builds?
Message-ID: <20140618122029.GA17790@fieldses.org>
References: <20140617223854.GC6168@fieldses.org>
 <53A15684.9000002@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53A15684.9000002@suse.cz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org

On Wed, Jun 18, 2014 at 11:06:12AM +0200, Michal Marek wrote:
> Dne 18.6.2014 00:38, J. Bruce Fields napsal(a):
> > The scripts I use for my kernel testing rely on the targz-pkg make
> > target.  After updating to 3.16-rc1 my scripts started failing.  In
> > scripts/package/buildtar:
> > 
> >   tmpdir="${objtree}/tar-install"
> >   tarball="${objtree}/linux-${KERNELRELEASE}-${ARCH}.tar"
> > ..
> >   #
> >   # Create the tarball
> >   #
> >   (
> >         cd "${tmpdir}"
> >         opts=
> >         if tar --owner=root --group=root --help >/dev/null 2>&1; then
> >                 opts="--owner=root --group=root"
> >         fi
> >         tar cf - boot/* lib/* $opts | ${compress} > "${tarball}${file_ext}"
> >   )
> 
> Thanks for the report, I'll fix it.

Thanks!

> > The changelog there says
> > 
> > 	The main Makefile sets its working directory to the object tree
> > 	and never changes it again. Therefore, we can use '.' instead of
> > 	the absolute path.
> > 
> > But the main Makefile also exports objtree, and a quick grep suggests
> > lots of other uses outside the main Makefile.
> 
> Do you have examples? Besides your report, I'm only aware of make
> deb-pkg and make *docs. What else?

I haven't looked.

I only note that grep finds 47 files referencing that variable, and
absent some argument that the remaining ones are correct, I'd be
inclined to revert.  But I don't know if there's other work that now
depends on the change.

In any case, your call.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/