Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756950AbaFROlu (ORCPT ); Wed, 18 Jun 2014 10:41:50 -0400 Received: from mail-oa0-f51.google.com ([209.85.219.51]:47007 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756901AbaFROlt (ORCPT ); Wed, 18 Jun 2014 10:41:49 -0400 MIME-Version: 1.0 In-Reply-To: <53A1A4A9.4060301@nvidia.com> References: <1403050362-20809-1-git-send-email-aplattner@nvidia.com> <53A1A4A9.4060301@nvidia.com> Date: Wed, 18 Jun 2014 20:11:48 +0530 Message-ID: Subject: Re: [PATCH] cpufreq: unlock when failing cpufreq_update_policy() From: Viresh Kumar To: Aaron Plattner Cc: "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "Rafael J. Wysocki" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18 June 2014 20:09, Aaron Plattner wrote: > I assume you meant "return -ENODEV"? Yeah, sorry :) >> down_write(&policy->rwsem); >> >> @@ -2279,10 +2277,10 @@ int cpufreq_update_policy(unsigned int cpu) >> >> ret = cpufreq_set_policy(policy, &new_policy); >> >> +no_policy: > > > 'no_policy' implied to me that policy was NULL, so this label should still > be renamed to 'unlock'. I'll send out a v2 that does this. Yeah. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/