Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753089AbaFRQsc (ORCPT ); Wed, 18 Jun 2014 12:48:32 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:38013 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbaFRQsa (ORCPT ); Wed, 18 Jun 2014 12:48:30 -0400 Date: Wed, 18 Jun 2014 17:48:22 +0100 From: Lee Jones To: Kumar Gala Cc: Kevin Hilman , Bjorn Andersson , Bjorn Andersson , Rob Herring , Mark Rutland , Liam Girdwood , Mark Brown , Josh Cartwright , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-arm-msm , Paul Walmsley Subject: Re: [PATCH v3 0/3] Qualcomm Resource Power Manager driver Message-ID: <20140618164822.GC25353@lee--X1> References: <1402944372-31901-1-git-send-email-bjorn.andersson@sonymobile.com> <7hvbrzbh1u.fsf@paris.lan> <7hzjha8b97.fsf@paris.lan> <842A7147-A2CC-42BD-9947-CBADF738DC92@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <842A7147-A2CC-42BD-9947-CBADF738DC92@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Jun 2014, Kumar Gala wrote: > > On Jun 18, 2014, at 10:53 AM, Kevin Hilman wrote: > > > Bjorn Andersson writes: > > > >> On Tue, Jun 17, 2014 at 10:07 AM, Kevin Hilman wrote: > >>> +Paul Walmsley > >>> > >>> Bjorn Andersson writes: > >>> > >>>> This series adds a regulator driver for the Resource Power Manager found in > >>>> Qualcomm 8660, 8960 and 8064 based devices. > >>>> > >>>> The RPM driver exposes resources to its child devices, that can be accessed to > >>>> implement drivers for the regulators, clocks and bus frequency control that's > >>>> owned by the RPM in these devices. > >>>> > >>>> Changes since v2: > >>>> - Fix copy-paste error in dt binding > >>>> - Correct incomplete move from mfd to soc > >>>> - Correct const mistake in regulator driver > >>>> > >>>> Changes since v1: > >>>> - Moved rpm driver to drivers/soc > >>> > >>> I'm not sure I follow the motivation for having this under drivers/soc? > >>> > >> Hi Kevin, > >> > >> I've made the argument that to me this is conceptually a black box > >> handling regulators, clocks and other stuff; hence similar to a PMIC, > >> which would fit nicely into drivers/mfd. > >> > >> I still think this is the case and now that I look back I didn't get > >> any pushback from Lee Jones so maybe the move was premature? > > > > Yes, IMO, the move was premature, but hopefully the drivers/soc folks > > can chime in an clarify the criteria for inclusion there. > > > > Kevin > > I dont agree, I think having this in drivers/soc means that we can > clearly go through drivers/soc in the future and look for patterns > across SoCs that should be re-factored. > Where MFD seems like its become the new drivers misc. Do you have any grounds for that statement? I only know of one driver which doesn't fit the bounds of a true MFD. If you know of more, I'd like to hear about it. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/