Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbaFRSAG (ORCPT ); Wed, 18 Jun 2014 14:00:06 -0400 Received: from mail-we0-f181.google.com ([74.125.82.181]:60868 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbaFRSAE (ORCPT ); Wed, 18 Jun 2014 14:00:04 -0400 Message-ID: <53A1D3A1.70202@gmail.com> Date: Wed, 18 Jun 2014 21:00:01 +0300 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Michal Marek , linux-kernel CC: Sam Ravnborg Subject: 9da0763 "kbuild: Use relative path ..." Broke my IDE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sir Michal Below patch broke my stupid yet useful IDE tool. I use kdevelop. kdevelop now gets confused on warnings and errors because it now comes out as (for example): ../fs/ext4/fsync.c:63:3: error: implicit declaration of function ‘iputddd’ [-Werror=implicit-function-declaration] >From what I understand kdevelop picks up the "[make] cd ..." outputs from make and will interpret those for finding gcc files output. But Linux Makefile will suppress these messages and kdevelop as no way to interpret the "../xxxx" I do not know what other IDEs do, but this one here is not smart enough. Could we please define a new input to Makefile that will revert to old behavior. like: KBUILD_FULL_PATH let me cook up a patch tomorrow (getting late here) Thanks Boaz The patch that broke it ---- >From 9da0763bdd82572be243fcf5161734f11568960f Mon Sep 17 00:00:00 2001 From: Michal Marek Date: Fri, 25 Apr 2014 23:25:18 +0200 Subject: [PATCH] kbuild: Use relative path when building in a subdir of the source tree When doing make O=, use '..' to refer to the source tree. This allows for more readable compiler messages, and, more importantly, it sets the VPATH to '..', so filenames in WARN_ON() etc. will be shorter. Acked-by: Sam Ravnborg Signed-off-by: Michal Marek --- Makefile | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3e134ec..f4702c1 100644 --- a/Makefile +++ b/Makefile @@ -149,7 +149,17 @@ else _all: modules endif -srctree := $(if $(KBUILD_SRC),$(KBUILD_SRC),.) +ifeq ($(KBUILD_SRC),) + # building in the source tree + srctree := . +else + ifeq ($(KBUILD_SRC)/,$(dir $(CURDIR))) + # building in a subdirectory of the source tree + srctree := .. + else + srctree := $(KBUILD_SRC) + endif +endif objtree := . src := $(srctree) obj := $(objtree) -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/