Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755025AbaFRTth (ORCPT ); Wed, 18 Jun 2014 15:49:37 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:40658 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754993AbaFRTtg (ORCPT ); Wed, 18 Jun 2014 15:49:36 -0400 Message-ID: <53A1ED49.4090201@ti.com> Date: Wed, 18 Jun 2014 22:49:29 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Rajendra Nayak CC: , , , , , , , , , Subject: Re: [PATCH 1/2] ARM: DRA7: hwmod: Add OCP2SCP3 module References: <1403093816-10960-1-git-send-email-rogerq@ti.com> <1403093816-10960-2-git-send-email-rogerq@ti.com> <53A1876B.2040701@ti.com> In-Reply-To: <53A1876B.2040701@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2014 03:34 PM, Rajendra Nayak wrote: > On Wednesday 18 June 2014 05:46 PM, Roger Quadros wrote: >> This module is needed for the SATA and PCIe PHYs. >> >> Signed-off-by: Roger Quadros >> Tested-by: Roger Quadros >> --- >> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> index 20b4398..cedef6b 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> @@ -1215,6 +1215,30 @@ static struct omap_hwmod dra7xx_ocp2scp1_hwmod = { >> }, >> }; >> >> +/* ocp2scp3 */ >> +static struct omap_hwmod dra7xx_ocp2scp3_hwmod; >> + >> +/* l4_cfg -> ocp2scp3 */ >> +static struct omap_hwmod_ocp_if dra7xx_l4_cfg__ocp2scp3 = { >> + .master = &dra7xx_l4_cfg_hwmod, >> + .slave = &dra7xx_ocp2scp3_hwmod, >> + .clk = "l4_root_clk_div", >> + .user = OCP_USER_MPU | OCP_USER_SDMA, >> +}; > > is it not possible to move this down in the file where all interface > structs are defined? yes, i'll send a v2 with this fixed as well as add .main_clk to the hwmod like in ocp2scp1. cheers, -roger > >> + >> +static struct omap_hwmod dra7xx_ocp2scp3_hwmod = { >> + .name = "ocp2scp3", >> + .class = &dra7xx_ocp2scp_hwmod_class, >> + .clkdm_name = "l3init_clkdm", >> + .prcm = { >> + .omap4 = { >> + .clkctrl_offs = DRA7XX_CM_L3INIT_OCP2SCP3_CLKCTRL_OFFSET, >> + .context_offs = DRA7XX_RM_L3INIT_OCP2SCP3_CONTEXT_OFFSET, >> + .modulemode = MODULEMODE_HWCTRL, >> + }, >> + }, >> +}; >> + >> /* >> * 'qspi' class >> * >> @@ -2672,6 +2696,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = { >> &dra7xx_l4_per1__mmc4, >> &dra7xx_l4_cfg__mpu, >> &dra7xx_l4_cfg__ocp2scp1, >> + &dra7xx_l4_cfg__ocp2scp3, >> &dra7xx_l3_main_1__qspi, >> &dra7xx_l4_cfg__sata, >> &dra7xx_l4_cfg__smartreflex_core, >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/