Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932804AbaFSOg0 (ORCPT ); Thu, 19 Jun 2014 10:36:26 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:40440 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932308AbaFSOgZ (ORCPT ); Thu, 19 Jun 2014 10:36:25 -0400 MIME-Version: 1.0 X-Originating-IP: [84.73.67.144] In-Reply-To: References: <1403131134-9533-1-git-send-email-bergo.torino@gmail.com> <20140619124507.GA12390@t400> Date: Thu, 19 Jun 2014 16:36:24 +0200 Message-ID: Subject: Re: [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common() From: Daniel Vetter To: Konrad Zapalowicz Cc: "Nikula, Jani" , Dave Airlie , intel-gfx , dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 19, 2014 at 4:35 PM, Daniel Vetter wrote: > The actual bug we seem to have is blowing up on the ggtt_unpin in > context_fini. Which is doubly-impossible: Gen4 doesn't have hw > contexts, so should have dctx->obj == NULL. And ring init failures > fail earlier so shouldn't even hit the context_fini code below the > cleanup_gem: label in driver_load. Seriously confused here. Also please retest with latest upstream, we've made the ring init failure non-letal for the driver. That should help you, too. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/