Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932890AbaFSOyy (ORCPT ); Thu, 19 Jun 2014 10:54:54 -0400 Received: from mail-vc0-f170.google.com ([209.85.220.170]:36629 "EHLO mail-vc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932490AbaFSOyw (ORCPT ); Thu, 19 Jun 2014 10:54:52 -0400 MIME-Version: 1.0 In-Reply-To: <1403186871-28204-1-git-send-email-gregory.clement@free-electrons.com> References: <1403186871-28204-1-git-send-email-gregory.clement@free-electrons.com> From: Rob Herring Date: Thu, 19 Jun 2014 09:54:31 -0500 Message-ID: Subject: Re: [PATCH] ARM: mvebu: Fix missing binding documentation for Armada 38x To: Gregory CLEMENT Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Ezequiel Garcia , "linux-arm-kernel@lists.infradead.org" , Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 19, 2014 at 9:07 AM, Gregory CLEMENT wrote: > For the Armada 380 and Armada 385 SoCs, the common bindings for those > 2 SoCs, was forgotten. This patch add the documentation for the > marvell,aramda38x property. > > Signed-off-by: Gregory CLEMENT > --- > Hi, > > This fix should be merged in 3.16. For 3.15 I am not sure as it is not > a regression. > > Thanks, > Gregory > > Documentation/devicetree/bindings/arm/armada-38x.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/armada-38x.txt b/Documentation/devicetree/bindings/arm/armada-38x.txt > index 11f2330a6554..b68bcb80d2de 100644 > --- a/Documentation/devicetree/bindings/arm/armada-38x.txt > +++ b/Documentation/devicetree/bindings/arm/armada-38x.txt > @@ -6,5 +6,9 @@ following property: > > Required root node property: > > +compatible: must contain "marvell,armada38x" > + > +Required root node property: > + > - compatible: must contain either "marvell,armada380" or > "marvell,armada385" depending on the variant of the SoC being used. This looks a bit strange. How about something like this: - compatible: must contain either "marvell,armada380" or "marvell,armada385" depending on the variant of the SoC being used and contain "marvell,armada38x". Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/