Date: Thu, 19 Jun 2014 16:35:02 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: James A Shackleford <shack@linux.com>
Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: vt6655: update out-of-date function
 declaration
Message-ID: <20140619233502.GA10708@kroah.com>
References: <1401675573-27734-1-git-send-email-shack@linux.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1401675573-27734-1-git-send-email-shack@linux.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org

On Sun, Jun 01, 2014 at 10:19:31PM -0400, James A Shackleford wrote:
> The function iwctl_siwscan() is defined in iwctl.c as:
> int iwctl_siwscan(struct net_device *dev,
> 		  struct iw_request_info *info,
> 		  struct iw_point *wrq,
> 		  char *extra)
> {
>   ...
> 
> This patch updates iwctl.h so that the type of the 3rd parameter (*wqr) in the
> function declaration matches the definition.
> 
> Signed-off-by: James A Shackleford <shack@linux.com>
> ---
>  drivers/staging/vt6655/iwctl.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/iwctl.h b/drivers/staging/vt6655/iwctl.h
> index 871bd7c..4ad5e48 100644
> --- a/drivers/staging/vt6655/iwctl.h
> +++ b/drivers/staging/vt6655/iwctl.h
> @@ -168,7 +168,7 @@ int iwctl_giwscan(struct net_device *dev,
>  
>  int iwctl_siwscan(struct net_device *dev,
>  		  struct iw_request_info *info,
> -		  struct iw_param *wrq,
> +		  struct iw_point *wrq,
>  		  char *extra);
>  

Why isn't the compiler catching this issue?  Should something include
this .h file?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/