Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934241AbaFTDpL (ORCPT ); Thu, 19 Jun 2014 23:45:11 -0400 Received: from mail-qa0-f49.google.com ([209.85.216.49]:41166 "EHLO mail-qa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932890AbaFTDpI (ORCPT ); Thu, 19 Jun 2014 23:45:08 -0400 MIME-Version: 1.0 In-Reply-To: <1403115247-8853-11-git-send-email-dianders@chromium.org> References: <1403115247-8853-1-git-send-email-dianders@chromium.org> <1403115247-8853-11-git-send-email-dianders@chromium.org> Date: Thu, 19 Jun 2014 21:45:07 -0600 X-Google-Sender-Auth: DJePm3kHhyknTej9US3-vDwijG8 Message-ID: Subject: Re: [PATCH v2 10/10] mfd: cros_ec: move EC interrupt to cros_ec_keyb From: Simon Glass To: Doug Anderson Cc: Lee Jones , Andrew Bresticker , Stephen Warren , Olof Johansson , Sonny Rao , linux-samsung-soc , Javier Martinez Canillas , Bill Richardson , Wolfram Sang , Mark Brown , Dmitry Torokhov , Samuel Ortiz , Geert Uytterhoeven , "linux-input@vger.kernel.org" , lk Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18 June 2014 12:14, Doug Anderson wrote: > From: Andrew Bresticker > > If we receive EC interrupts after the cros_ec driver has probed, but > before the cros_ec_keyb driver has probed, the cros_ec IRQ handler > will not run the cros_ec_keyb notifier and the EC will leave the IRQ > line asserted. The cros_ec IRQ handler then returns IRQ_HANDLED and > the resulting flood of interrupts causes the machine to hang. > > Since the EC interrupt is currently only used for the keyboard, move > the setup and handling of the EC interrupt to the cros_ec_keyb driver. > > Signed-off-by: Andrew Bresticker > Signed-off-by: Doug Anderson Reviewed-by: Simon Glass We never needed an EC-level interrupt, and have shipped at least three products now that use this code, so I think it is safe enough to declare that we won't need it. Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/