Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934591AbaFTF5T (ORCPT ); Fri, 20 Jun 2014 01:57:19 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:61397 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933667AbaFTF5Q (ORCPT ); Fri, 20 Jun 2014 01:57:16 -0400 MIME-Version: 1.0 In-Reply-To: <20140618122646.GS19730@lukather> References: <1403016777-15121-1-git-send-email-wens@csie.org> <1403016777-15121-18-git-send-email-wens@csie.org> <20140618122646.GS19730@lukather> From: Chen-Yu Tsai Date: Fri, 20 Jun 2014 13:56:54 +0800 X-Google-Sender-Auth: XMp0cFRr7PFS0E7gIpM_ZUyzhLs Message-ID: Subject: Re: [linux-sunxi] Re: [PATCH v2 17/20] ARM: sunxi: Introduce Allwinner A23 support To: linux-sunxi Cc: Greg Kroah-Hartman , Samuel Ortiz , Lee Jones , Rob Herring , Mike Turquette , Emilio Lopez , Linus Walleij , linux-serial@vger.kernel.org, linux-arm-kernel , devicetree , linux-kernel , Boris BREZILLON , Luc Verhaegen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 18, 2014 at 8:26 PM, Maxime Ripard wrote: > On Tue, Jun 17, 2014 at 10:52:54PM +0800, Chen-Yu Tsai wrote: >> The Allwinner A23 is a dual-core Cortex-A7-based SoC. It re-uses most of >> the IPs found in previous SoCs, notably the A31. >> >> Signed-off-by: Chen-Yu Tsai >> --- >> arch/arm/mach-sunxi/Kconfig | 8 ++++++++ >> arch/arm/mach-sunxi/sunxi.c | 10 ++++++++++ >> 2 files changed, 18 insertions(+) >> >> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig >> index 0fbd4f1..6434e3b 100644 >> --- a/arch/arm/mach-sunxi/Kconfig >> +++ b/arch/arm/mach-sunxi/Kconfig >> @@ -35,4 +35,12 @@ config MACH_SUN7I >> select HAVE_ARM_ARCH_TIMER >> select SUN5I_HSTIMER >> >> +config MACH_SUN8I >> + bool "Allwinner A23 (sun8i) SoCs support" >> + default ARCH_SUNXI >> + select ARCH_HAS_RESET_CONTROLLER >> + select ARM_GIC >> + select MFD_SUN6I_PRCM >> + select RESET_CONTROLLER >> + >> endif >> diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c >> index 3f9587b..962ff30 100644 >> --- a/arch/arm/mach-sunxi/sunxi.c >> +++ b/arch/arm/mach-sunxi/sunxi.c >> @@ -53,3 +53,13 @@ static const char * const sun7i_board_dt_compat[] = { >> DT_MACHINE_START(SUN7I_DT, "Allwinner sun7i (A20) Family") >> .dt_compat = sun7i_board_dt_compat, >> MACHINE_END >> + >> +static const char * const sun8i_board_dt_compat[] = { >> + "allwinner,sun8i-a23", >> + NULL, >> +}; >> + >> +DT_MACHINE_START(SUN8I_DT, "Allwinner sun8i (A23) Family") >> + .init_time = sun6i_timer_init, > > I haven't seen anything in your code that needed to use this > function. Am I missing something? My mistake. From the log I thought all timers needed the reset controller. Turns out only the high speed timer does. I'll remove the call in the next version. ChenYu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/