Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934624AbaFTQVi (ORCPT ); Fri, 20 Jun 2014 12:21:38 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.227]:60376 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932155AbaFTQVh (ORCPT ); Fri, 20 Jun 2014 12:21:37 -0400 Date: Fri, 20 Jun 2014 12:21:35 -0400 From: Steven Rostedt To: Linus Torvalds Cc: Linux Kernel Mailing List , Ingo Molnar , Andrew Morton , Jiri Kosina , Michal Hocko , Jan Kara , Frederic Weisbecker , Dave Anderson , Petr Mladek Subject: Re: [RFC][PATCH 1/3] trace_seq: Move the trace_seq code to lib/ Message-ID: <20140620122135.17a90bfb@gandalf.local.home> In-Reply-To: References: <20140619213329.478113470@goodmis.org> <20140619213952.058255809@goodmis.org> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Jun 2014 18:45:57 -1000 Linus Torvalds wrote: > On Thu, Jun 19, 2014 at 11:33 AM, Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > The trace_seq functions are rather useful outside of tracing. > > They are? They will be. > Why and where? Why? for NMI safe output. Where? Well, in patch 3. :-) > And why are they still called "trace_xyz()" then? Good point, I'd like to rename it too. It was designed like seq_file, so what about seq_buffer_xxx()? > > That commit message is useless and contains no actual information. Yeah, it was rather weak. It was quick and not a stand alone. It was dependent on reading the rest of the patches. OK, I can update the name and make a better change log on the move. Of course if you hate this patch series, I can just not waste any time on it. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/