Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967064AbaFTSwy (ORCPT ); Fri, 20 Jun 2014 14:52:54 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:29905 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965992AbaFTSww (ORCPT ); Fri, 20 Jun 2014 14:52:52 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 96.249.243.124 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19mbhX27sWvlOvn9DHaDBQRDYMQtSuMHP4= X-DKIM: OpenDKIM Filter v2.0.1 titan 55BF6594515 Date: Fri, 20 Jun 2014 14:52:41 -0400 From: Jason Cooper To: Gregory CLEMENT Cc: Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Grant Likely , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: mvebu: Fix missing binding documentation for Armada 38x Message-ID: <20140620185241.GC21711@titan.lakedaemon.net> References: <1403196043-6317-1-git-send-email-gregory.clement@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403196043-6317-1-git-send-email-gregory.clement@free-electrons.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 19, 2014 at 06:40:43PM +0200, Gregory CLEMENT wrote: > For the Armada 380 and Armada 385 SoCs, the common bindings for those > 2 SoCs, was forgotten. This patch add the documentation for the > marvell,aramda38x property. > > Signed-off-by: Gregory CLEMENT > -- > Hi, > > This fix should be merged in 3.16. For 3.15 I am not sure as it is not > a regression. > > Changelog: > v1->v2 > > - Reformulate to make clear that we will need marvell,armada38x _and_ a > SoC specific string. For consistency I duplicated what we have done in > armada-370-xp.txt > > > Thanks, > Gregory > > > Documentation/devicetree/bindings/arm/armada-38x.txt | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/armada-38x.txt b/Documentation/devicetree/bindings/arm/armada-38x.txt > index 11f2330a6554..fa08760046df 100644 > --- a/Documentation/devicetree/bindings/arm/armada-38x.txt > +++ b/Documentation/devicetree/bindings/arm/armada-38x.txt > @@ -6,5 +6,18 @@ following property: > > Required root node property: > > - - compatible: must contain either "marvell,armada380" or > - "marvell,armada385" depending on the variant of the SoC being used. > +compatible: must contain "marvell,armada38x" I agree with Sergei on this one. We generally avoid wildcards in compatible strings. Is there a use case where specifying one of the below wouldn't be sufficient? > + > +In addition, boards using the Marvell Armada 380 SoC shall have the > +following property: > + > +Required root node property: > + > +compatible: must contain "marvell,armada380" > + > +In addition, boards using the Marvell Armada 385 SoC shall have the > +following property: > + > +Required root node property: > + > +compatible: must contain "marvell,armada385" thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/