MIME-Version: 1.0
In-Reply-To: <53A48553.2080504@ti.com>
References: <1401981720-6946-1-git-send-email-santosh.shilimkar@ti.com>
 <CAL_JsqJAtWnHKPVpDsdOOzT_X=npc3hroLNTGqULM2SJr=1OEg@mail.gmail.com>
 <53A46CB7.1030109@ti.com> <4193075.zZSpRTFEYz@wuerfel> <53A48553.2080504@ti.com>
From: Rob Herring <robherring2@gmail.com>
Date: Fri, 20 Jun 2014 14:46:17 -0500
Message-ID: <CAL_JsqLYho6dRA=-ovKqF7H4EGHJcH_aN3ywd+76oXSprfTMbQ@mail.gmail.com>
Subject: Re: [PATCH] dt/documentation: add specification of dma bus information
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Russell King <linux@arm.linux.org.uk>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Kumar Gala <galak@codeaurora.org>,
        Grant Likely <grant.likely@linaro.org>,
        Fabio Estevam <festevam@gmail.com>,
        Shawn Guo <shawn.guo@freescale.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org

On Fri, Jun 20, 2014 at 2:02 PM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
> On Friday 20 June 2014 02:56 PM, Arnd Bergmann wrote:
>> On Friday 20 June 2014 13:17:43 Santosh Shilimkar wrote:
>>>>> +                       dma-coherent;
>>>>> +                       dma-ranges;
>>>>> +
>>>>> +                       dwc3@2690000 {
>>>>> +                               compatible = "synopsys,dwc3";
>>>>> +                               [...]
>>>>> +                       };
>>>>
>>>> This example is a bit strange. I don't understand the relationship
>>>> between keystone-dwc3 and synopsys,dwc3, nor do I want to. I'd prefer
>>>> to see a simple example here.
>>
>>
>>>> dma-ranges is a property of the parent which you show, but
>>>> dma-coherent originally was a property of the bus master itself. While
>>>> we need to support that, are we changing that? We need to be clear on
>>>> where the property belongs even if the kernel is more lax.
>>>>
>>> I don't think we are changing it fundamentally but may be I missing
>>> your point. The dma-coherent as is now a per-device property.
>>> USB is one of the bus master supports coherency and hence showed
>>> up in above example.
>>
>> I think it's enough if you just drop the "synopsys,dwc3" node and the
>> intermediate dma-ranges property from the example, leaving the
>> dma-coherent property in the "ti,keystone-dwc3" node.
>>
> Thanks Arnd. That should avoid the confusion. Just to see if Rob is
> fine by it, the example will look like below.

Yes. Looks fine.

Rob

>
> Example:
> soc {
>                 compatible = "ti,keystone","simple-bus";
>                 ranges = <0x0 0x0 0x0 0xc0000000>;
>                 dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
>
>                 [...]
>
>                 usb: usb@2680000 {
>                         compatible = "ti,keystone-dwc3";
>
>                         [...]
>                         dma-coherent;
>                 };
> };
>
> Regards,
> Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/