Message-ID: <1403294880.4076.7.camel@joe-AO725>
Subject: Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in
 halbcoutsrc
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
        Larry Finger <Larry.Finger@lwfinger.net>
Cc: Nicholas Krause <xerofoify@gmail.com>, gregkh@linuxfoundation.org,
        devel@driverdev.osuosl.org, pebolle@tiscali.nl, himangi774@gmail.com,
        bergo.torino@gmail.com, linux-kernel@vger.kernel.org
Date: Fri, 20 Jun 2014 13:08:00 -0700
In-Reply-To: <20140620195926.GY5500@mwanda>
References: <1403283410-7022-1-git-send-email-xerofoify@gmail.com>
	 <20140620195926.GY5500@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Fri, 2014-06-20 at 22:59 +0300, Dan Carpenter wrote:
> On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote:
> > Rewrites the wireless check for legacy checking in function
> > halbtc_legacy to check for both Mode A and B.
> 
> You're just guessing that A and B were intended but it could have been
> something B and G...
> 
> Don't do this.  Just leave the static checker warning there so someone
> can fix it properly instead of introducing a second new bug and hiding
> the warning so it's impossible to find.
> 

It's most likely G anyway:

drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.c:     if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_G))
drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c:     if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_B))

Larry probably has a better idea.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/