Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172AbaFTUca (ORCPT ); Fri, 20 Jun 2014 16:32:30 -0400 Received: from mail-ve0-f170.google.com ([209.85.128.170]:62312 "EHLO mail-ve0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbaFTUc2 (ORCPT ); Fri, 20 Jun 2014 16:32:28 -0400 MIME-Version: 1.0 In-Reply-To: <1403251396-17487-1-git-send-email-tushar.b@samsung.com> References: <1403251396-17487-1-git-send-email-tushar.b@samsung.com> Date: Fri, 20 Jun 2014 13:32:26 -0700 X-Google-Sender-Auth: PKVcKCvkBntWVJ9Dj50zvuSQ0nY Message-ID: Subject: Re: [PATCH 1/2] ASoC: max98090: Add max98091 compatible string From: Doug Anderson To: Tushar Behera Cc: linux-samsung-soc , alsa-devel@alsa-project.org, "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Kukjin Kim , tiwai@suse.de, "broonie@kernel.org" , Liam Girdwood , Kumar Gala , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring , Tushar Behera , Wonjoon Lee Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tushar, On Fri, Jun 20, 2014 at 1:03 AM, Tushar Behera wrote: > From: Wonjoon Lee > > The MAX98091 CODEC is the same as MAX98090 CODEC, but with an extra > microphone. Existing driver for MAX98090 CODEC already has support > for MAX98091 CODEC. Adding proper compatible string so that MAX98091 > CODEC can be specified from device tree. > > Signed-off-by: Wonjoon Lee > Signed-off-by: Doug Anderson > Signed-off-by: Tushar Behera > --- > > Picked from https://chromium-review.googlesource.com/#/c/184091/ > > .../devicetree/bindings/sound/max98090.txt | 2 +- > sound/soc/codecs/max98090.c | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/max98090.txt b/Documentation/devicetree/bindings/sound/max98090.txt > index a5e63fa..c454e67 100644 > --- a/Documentation/devicetree/bindings/sound/max98090.txt > +++ b/Documentation/devicetree/bindings/sound/max98090.txt > @@ -4,7 +4,7 @@ This device supports I2C only. > > Required properties: > > -- compatible : "maxim,max98090". > +- compatible : "maxim,max98090" or "maxim,max98091". > > - reg : The I2C address of the device. > > diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c > index f5fccc7..4f5534d 100644 > --- a/sound/soc/codecs/max98090.c > +++ b/sound/soc/codecs/max98090.c > @@ -2460,12 +2460,14 @@ static const struct dev_pm_ops max98090_pm = { > > static const struct i2c_device_id max98090_i2c_id[] = { > { "max98090", MAX98090 }, > + { "max98091", MAX98091 }, optional: This would allow you to add some extra error checking in max98090_probe() to make sure that the device-tree specified device matched the device that was detected. That could be in a future patch, though. Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/