Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932469AbaFUHOF (ORCPT ); Sat, 21 Jun 2014 03:14:05 -0400 Received: from smtp-69.nebula.fi ([83.145.220.69]:40845 "EHLO smtp.nebula.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757585AbaFUHOC (ORCPT ); Sat, 21 Jun 2014 03:14:02 -0400 Date: Sat, 21 Jun 2014 10:13:42 +0300 From: Stefan Kristiansson To: Jason Cooper Cc: Jonas Bonn , Geert Uytterhoeven , "linux-kernel@vger.kernel.org" , linux , Thomas Gleixner , "devicetree@vger.kernel.org" Subject: Re: [PATCH v4] openrisc: irq: use irqchip framework Message-ID: <20140621071340.GA27032@chokladfabriken.org> References: <1401136302-27654-1-git-send-email-stefan.kristiansson@saunalahti.fi> <53843508.7060007@southpole.se> <20140529202806.GA9387@chokladfabriken.org> <20140621020430.GA21711@titan.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140621020430.GA21711@titan.lakedaemon.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 20, 2014 at 10:04:30PM -0400, Jason Cooper wrote: > On Thu, May 29, 2014 at 11:28:08PM +0300, Stefan Kristiansson wrote: > > But I don't understand the purpose of the versioning here, > > there will never be any other or1200-pic version than the one that currently > > exists, so IMO "or1200" should be enough versioning information. > > I'm horribly unfamiliar with openrisc, but compatible strings are > compatible strings. ;-) > > Is the *actual* IP block called or1200-pic? Or is it, eg or1235-pic, and > you're using or1200-pic as a generic catch-all? > No, the or1200-pic is a part of the or1200 cpu that is one (there are several others) implementation of the OpenRISC 1000 architecture. The quirk here is that the OpenRISC 1000 architecture specification specifies how a PIC should be implemented, but or1200 doesn't follow that to 100%. Thus, it need a bit of special care. The implementations that follow the specification can use the or1k-pic-level and or1k-pic-edge variants. > Please use the specific IP name without wildcards. That compatible > string will then be used on that IP and future IP that is compatible > with the original IP. Once an incompatible change is introduced, then > we'll create a new compatible string, say or1300-pic, or or1237-pic. > The point I tried to make above was that if a change would be made to the pic implementation in or1200, it should be a change to conform to the specification. > When in doubt, be specific. I don't think the '-rtlsvnXYZ' should be > necessary, though. > I agree, and I think 'or1200-pic' is specific enough in this case. Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/