Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934035AbaFUIhk (ORCPT ); Sat, 21 Jun 2014 04:37:40 -0400 Received: from canardo.mork.no ([148.122.252.1]:53408 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754734AbaFUIhi (ORCPT ); Sat, 21 Jun 2014 04:37:38 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <1403296607-6065-1-git-send-email-fabf@skynet.be> References: <1403296607-6065-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH 1/1] net/dsa/dsa.c: remove null test before kfree From: =?ISO-8859-1?Q?Bj=F8rn_Mork?= Date: Sat, 21 Jun 2014 10:37:24 +0200 To: Fabian Frederick , linux-kernel@vger.kernel.org CC: "David S. Miller" , Grant Likely , netdev@vger.kernel.org Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20 June 2014 22:36:47 CEST, Fabian Frederick wrote: >Fix checkpatch warning: >WARNING: kfree(NULL) is safe this check is probably not required "probably not" implies that there are cases where the check *is* required. That means that your commit message should explain why this particular check is redundant. I haven't analyzed your changes here, so they could be fine for all I know. My point is that such analysis is your job when submitting cleanups like this one. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/