Date: Sat, 21 Jun 2014 11:36:53 +0200
From: Fabian Frederick <fabf@skynet.be>
To: =?ISO-8859-1?Q?Bj=F8rn?= Mork <bjorn@mork.no>
Cc: linux-kernel@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Grant Likely <grant.likely@linaro.org>, netdev@vger.kernel.org,
        Joe Perches <joe@perches.com>
Subject: Re: [PATCH 1/1] net/dsa/dsa.c: remove null test before kfree
Message-Id: <20140621113653.6b2dd148b35a6ecfb7c08cce@skynet.be>
In-Reply-To: <b991e868-c253-4b1a-8c95-56106c36d512@email.android.com>
References: <1403296607-6065-1-git-send-email-fabf@skynet.be>
	<b991e868-c253-4b1a-8c95-56106c36d512@email.android.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org

On Sat, 21 Jun 2014 10:37:24 +0200
Bj?rn Mork <bjorn@mork.no> wrote:

> 
> 
> On 20 June 2014 22:36:47 CEST, Fabian Frederick <fabf@skynet.be> wrote:
> >Fix checkpatch warning:
> >WARNING: kfree(NULL) is safe this check is probably not required
> 
> "probably not" implies that there are cases where the check *is* required.  That means that your commit message should explain why this particular check is redundant.
> 
> I haven't analyzed your changes here, so they could be fine for all I know. My point is that such analysis is your job when submitting cleanups like this one.
> 
> 
> 
AFAIK, any

if(foo)
	kfree(foo)
	
can be updated to kfree(foo) but

if (foo){
	kfree(foo)
	do something else
}

has to be evaluated ; reason for the "probably" in warning message.
If I'm wrong maybe we could be more verbose in checkpatch :)
(I added Joe Perches in Cc list ; maybe he can help here)

Fabian

> Bj?rn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/