Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753911AbaFUSSu (ORCPT ); Sat, 21 Jun 2014 14:18:50 -0400 Received: from mail-pb0-f54.google.com ([209.85.160.54]:47917 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753456AbaFUSSs (ORCPT ); Sat, 21 Jun 2014 14:18:48 -0400 MIME-Version: 1.0 X-Originating-IP: [67.83.169.196] In-Reply-To: <20140606071345.6788.23744.stgit@kbuild-fedora.novalocal> References: <20140606071338.6788.799.stgit@kbuild-fedora.novalocal> <20140606071345.6788.23744.stgit@kbuild-fedora.novalocal> Date: Sat, 21 Jun 2014 14:18:48 -0400 Message-ID: Subject: Re: [PATCH -tip 1/4] perf/probe: Improve error message for unknown member of data structure From: Patrick Palka To: Masami Hiramatsu Cc: Jiri Olsa , Linux Kernel Mailing List , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Paul Mackerras , Namhyung Kim , Jiri Olsa , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 6, 2014 at 3:13 AM, Masami Hiramatsu wrote: > Improve the error message if we can not find given member in > the given structure. Currently perf probe shows a wrong error > message as below. > > ----- > # perf probe getname_flags:65 "result->BOGUS" > result(type:filename) has no member BOGUS. > Failed to find 'result' in this function. > Error: Failed to add events. (-22) > ----- > > The first message is correct, but the second one is not, since > we didn't fail to find a variable but fails to find the member > of given variable. > > ----- > # perf probe getname_flags:65 "result->BOGUS" > result(type:filename) has no member BOGUS. > Error: Failed to add events. (-22) > ----- > > With this patch, the error message shows only the first one. > And if we really failed to find given variable, it tells us so. > > ----- > # perf probe getname_flags:65 "BOGUS" > Failed to find 'BOGUS' in this function. > Error: Failed to add events. (-2) > ----- > > Signed-off-by: Masami Hiramatsu > Reported-by: Arnaldo Carvalho de Melo > Cc: Peter Zijlstra > Cc: Paul Mackerras > Cc: Ingo Molnar > Cc: Namhyung Kim > Cc: Jiri Olsa > --- > tools/perf/util/probe-finder.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c > index 9d8eb26..ce8faf4 100644 > --- a/tools/perf/util/probe-finder.c > +++ b/tools/perf/util/probe-finder.c > @@ -573,14 +573,13 @@ static int find_variable(Dwarf_Die *sc_die, struct probe_finder *pf) > if (!die_find_variable_at(sc_die, pf->pvar->var, pf->addr, &vr_die)) { > /* Search again in global variables */ > if (!die_find_variable_at(&pf->cu_die, pf->pvar->var, 0, &vr_die)) > + pr_warning("Failed to find '%s' in this function.\n", > + pf->pvar->var); > ret = -ENOENT; It looks like you're missing a pair of braces here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/