Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbaFVOnM (ORCPT ); Sun, 22 Jun 2014 10:43:12 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:33103 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbaFVOnK (ORCPT ); Sun, 22 Jun 2014 10:43:10 -0400 Message-ID: <1403448187.1949.9.camel@jarvis.lan> Subject: Re: [RFC] Tux3 for review From: James Bottomley To: Daniel Phillips Cc: =?UTF-8?Q?Luk=C3=A1=C5=A1?= Czerner , Pavel Machek , Dave Chinner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linus Torvalds , Andrew Morton Date: Sun, 22 Jun 2014 07:43:07 -0700 In-Reply-To: References: <5376B273.7000800@partner.samsung.com> <20140518235555.GC18954@dastard> <537AA802.408@phunq.net> <20140520031802.GF18954@dastard> <20140613103216.GA4589@amd.pavel.ucw.cz> <02d3b094-808c-4b17-903d-1280d451704b@phunq.net> <20140613202039.GA23872@amd.pavel.ucw.cz> <1402932354.2197.61.camel@dabdike.int.hansenpartnership.com> <20140619082129.GA4309@xo-6d-61-c0.localdomain> <1403378941.2177.24.camel@dabdike.int.hansenpartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2014-06-21 at 20:32 -0700, Daniel Phillips wrote: > On Saturday, June 21, 2014 12:29:01 PM PDT, James Bottomley wrote: > > On Thu, 2014-06-19 at 14:58 -0700, Daniel Phillips wrote: > >> We already removed 450 lines of core kernel workarounds from Tux3 with > an > >> approach that was literally cut and pasted from one of Dave's > >> emails. Then > >> Dave changed his mind. Now the Tux3 team has been assigned a research > >> project to improve core kernel writeback instead of simply adapting the > >> approach that is already proven to work well enough. That is a rather > >> blatant example of "perfect is the enemy of good enough". Please read > the > >> thread. > > > > That's a bit disingenuous: the concern has always been how page forking > > interacted with writeback. It's not new, it was one of the major things > > brought up at LSF 14 months ago, so you weren't just assigned this. > > [citation needed] Really? I was there; I remember and it's in my notes of the discussion. However, it's also in Jon's at paragraph 6 if you need to refer to something to refresh your memory. However, when it was spotted isn't the issue; how we add tux3 without a large maintenance burden on writeback is, as I carefully explained in the rest of the email you cut. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/