Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbaFWCVZ (ORCPT ); Sun, 22 Jun 2014 22:21:25 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:49755 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbaFWCVQ (ORCPT ); Sun, 22 Jun 2014 22:21:16 -0400 Message-ID: <53A78F14.8070705@hitachi.com> Date: Mon, 23 Jun 2014 11:21:08 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Patrick Palka Cc: Jiri Olsa , Linux Kernel Mailing List , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Paul Mackerras , Namhyung Kim , Jiri Olsa , Ingo Molnar Subject: Re: [PATCH -tip 1/4] perf/probe: Improve error message for unknown member of data structure References: <20140606071338.6788.799.stgit@kbuild-fedora.novalocal> <20140606071345.6788.23744.stgit@kbuild-fedora.novalocal> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2014/06/22 3:18), Patrick Palka wrote: > On Fri, Jun 6, 2014 at 3:13 AM, Masami Hiramatsu > wrote: >> Improve the error message if we can not find given member in >> the given structure. Currently perf probe shows a wrong error >> message as below. >> >> ----- >> # perf probe getname_flags:65 "result->BOGUS" >> result(type:filename) has no member BOGUS. >> Failed to find 'result' in this function. >> Error: Failed to add events. (-22) >> ----- >> >> The first message is correct, but the second one is not, since >> we didn't fail to find a variable but fails to find the member >> of given variable. >> >> ----- >> # perf probe getname_flags:65 "result->BOGUS" >> result(type:filename) has no member BOGUS. >> Error: Failed to add events. (-22) >> ----- >> >> With this patch, the error message shows only the first one. >> And if we really failed to find given variable, it tells us so. >> >> ----- >> # perf probe getname_flags:65 "BOGUS" >> Failed to find 'BOGUS' in this function. >> Error: Failed to add events. (-2) >> ----- >> >> Signed-off-by: Masami Hiramatsu >> Reported-by: Arnaldo Carvalho de Melo >> Cc: Peter Zijlstra >> Cc: Paul Mackerras >> Cc: Ingo Molnar >> Cc: Namhyung Kim >> Cc: Jiri Olsa >> --- >> tools/perf/util/probe-finder.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c >> index 9d8eb26..ce8faf4 100644 >> --- a/tools/perf/util/probe-finder.c >> +++ b/tools/perf/util/probe-finder.c >> @@ -573,14 +573,13 @@ static int find_variable(Dwarf_Die *sc_die, struct probe_finder *pf) >> if (!die_find_variable_at(sc_die, pf->pvar->var, pf->addr, &vr_die)) { >> /* Search again in global variables */ >> if (!die_find_variable_at(&pf->cu_die, pf->pvar->var, 0, &vr_die)) >> + pr_warning("Failed to find '%s' in this function.\n", >> + pf->pvar->var); >> ret = -ENOENT; > > It looks like you're missing a pair of braces here. Oops, right! Thank you very much! -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/