Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbaFWDHZ (ORCPT ); Sun, 22 Jun 2014 23:07:25 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:39911 "EHLO mail-pb0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbaFWDHY (ORCPT ); Sun, 22 Jun 2014 23:07:24 -0400 Message-ID: <53A799E5.7040609@gmail.com> Date: Mon, 23 Jun 2014 11:07:17 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Guenter Roeck , Lennox Wu CC: Liqin Chen , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros References: <53A66000.4010208@gmail.com> <53A70420.4010005@roeck-us.net> In-Reply-To: <53A70420.4010005@roeck-us.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/23/2014 12:28 AM, Guenter Roeck wrote: > On 06/22/2014 01:09 AM, Lennox Wu wrote: >> Hi Chen, >> Do you find other modules except device modules cause issues of >> compiling? >> The applications of Score are limited. Acutally, some errors never occur >> in the limited applications, for example, the conbination consists of >> Score and the timer of SuperH. I'm not sure we should handle this kind >> of error. >> If the rule is that we should make sure "all" modules can be compiled >> with Score, we will do it. >> However, we still thanks for your check. >> > > Other architectures don't care about buildability of allmodconfig or > allyesconfig > (arm is a good [or maybe bad] example), so it is for sure not mandatory. > On the other side, fixing such problems - especially when you have someone > doing it for you - may prevent problems down the road, so while not > mandatory > I consider it a useful goal to achieve. > > If there is a driver which doesn't make sense to build at all, such as > the SuperH > timer driver mentioned above, it can always be excluded from building > with Kconfig. > If that causes opposition for some reason, you can still ignore that it > fails > to build. > Yeah, what Guenter said is fine to me. Although allmodconfig is not mandatory, it is still a useful goal to achieve. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/