Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752117AbaFWGMU (ORCPT ); Mon, 23 Jun 2014 02:12:20 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:47874 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697AbaFWGMS (ORCPT ); Mon, 23 Jun 2014 02:12:18 -0400 MIME-Version: 1.0 In-Reply-To: <1403503334-4816-1-git-send-email-tushar.b@samsung.com> References: <1403503334-4816-1-git-send-email-tushar.b@samsung.com> Date: Mon, 23 Jun 2014 11:42:16 +0530 X-Google-Sender-Auth: LvTwMcQuuqpMekbJF8hrqwFYhNc Message-ID: Subject: Re: [PATCH] serial: samsung: Remove redundant label From: Sachin Kamat To: Tushar Behera Cc: open list , linux-serial@vger.kernel.org, Jiri Slaby , Greg Kroah-Hartman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 23, 2014 at 11:32 AM, Tushar Behera wrote: > probe_err label only returns the error code. This label can be removed > and the error code can be returned directly. > > Signed-off-by: Tushar Behera > --- > drivers/tty/serial/samsung.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c > index c1d3ebd..bf93010 100644 > --- a/drivers/tty/serial/samsung.c > +++ b/drivers/tty/serial/samsung.c > @@ -1303,7 +1303,7 @@ static int s3c24xx_serial_probe(struct platform_device *pdev) > > ret = s3c24xx_serial_init_port(ourport, pdev); > if (ret < 0) > - goto probe_err; > + return ret; > > if (!s3c24xx_uart_drv.state) { > ret = uart_register_driver(&s3c24xx_uart_drv); > @@ -1335,9 +1335,6 @@ static int s3c24xx_serial_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "failed to add cpufreq notifier\n"); > > return 0; > - > - probe_err: > - return ret; > } > > static int s3c24xx_serial_remove(struct platform_device *dev) > -- Looks good. Reviewed-by: Sachin Kamat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/