Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751525AbaFWHZS (ORCPT ); Mon, 23 Jun 2014 03:25:18 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:34291 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbaFWHZQ (ORCPT ); Mon, 23 Jun 2014 03:25:16 -0400 Message-ID: <53A7D5C4.6090201@ti.com> Date: Mon, 23 Jun 2014 12:52:44 +0530 From: Sricharan R User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jason Cooper CC: , , , , , , , , , , Subject: Re: [PATCH V3 16/16] irqchip: crossbar: allow for quirky hardware with direct hardwiring of GIC References: <1402917796-31574-1-git-send-email-r.sricharan@ti.com> <1402917796-31574-17-git-send-email-r.sricharan@ti.com> <20140621025723.GF21711@titan.lakedaemon.net> In-Reply-To: <20140621025723.GF21711@titan.lakedaemon.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jason, On Saturday 21 June 2014 08:27 AM, Jason Cooper wrote: > On Mon, Jun 16, 2014 at 04:53:16PM +0530, Sricharan R wrote: >> From: Nishanth Menon >> >> On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6, 10, 131, >> 132, 133 are direct wired to hardware blocks bypassing crossbar. >> This quirky implementation is *NOT* supposed to be the expectation >> of crossbar hardware usage. However, these are already marked in our >> description of the hardware with SKIP and RESERVED where appropriate. >> >> Unfortunately, we need to be able to refer to these hardwired IRQs. >> So, to request these, crossbar driver can use the existing information >> from it's table that these SKIP/RESERVED maps are direct wired sources >> and generic allocation/programming of crossbar should be avoided. >> >> Signed-off-by: Nishanth Menon >> Signed-off-by: Sricharan R >> --- >> .../devicetree/bindings/arm/omap/crossbar.txt | 12 ++++++++++-- >> drivers/irqchip/irq-crossbar.c | 20 ++++++++++++++++++-- >> 2 files changed, 28 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/omap/crossbar.txt b/Documentation/devicetree/bindings/arm/omap/crossbar.txt >> index 8210ea4..438ccab 100644 >> --- a/Documentation/devicetree/bindings/arm/omap/crossbar.txt >> +++ b/Documentation/devicetree/bindings/arm/omap/crossbar.txt >> @@ -42,8 +42,10 @@ Documentation/devicetree/bindings/arm/gic.txt for further details. >> >> An interrupt consumer on an SoC using crossbar will use: >> interrupts = >> -request number shall be between 0 to that described by >> -"ti,max-crossbar-sources" >> +When the request number is between 0 to that described by >> +"ti,max-crossbar-sources", it is assumed to be a crossbar mapping. If the >> +request_number is greater than "ti,max-crossbar-sources", then it is mapped as a >> +quirky hardware mapping direct to GIC. >> >> Example: >> device_x@0x4a023000 { >> @@ -51,3 +53,9 @@ Example: >> interrupts = ; >> ... >> }; >> + >> + device_y@0x4a033000 { >> + /* Direct mapped GIC SPI 1 used */ >> + interrupts = ; > > Ideally, I'd like to see a macro here so that it's clear that we crossed > a magic threshold. eg: > > #define MAX_SOURCES 400 > #define DIRECT_IRQ(irq) (MAX_SOURCES + irq) > ... > interrupts = ; > > and, then: > > ti,max-crossbar-sources = ; > Ok, thats more good for readability. Will add that macro then. Regards, Sricharan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/