Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbaFWHfI (ORCPT ); Mon, 23 Jun 2014 03:35:08 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56576 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbaFWHfH (ORCPT ); Mon, 23 Jun 2014 03:35:07 -0400 Date: Mon, 23 Jun 2014 09:35:00 +0200 From: Peter Zijlstra To: Andi Kleen Cc: Stephane Eranian , LKML , "mingo@elte.hu" , Joe Mario , Don Zickus , Jiri Olsa , Arnaldo Carvalho de Melo Subject: Re: [PATCH 1/2] perf/x86: update Haswell PEBS event constraints Message-ID: <20140623073500.GJ19860@laptop.programming.kicks-ass.net> References: <1403193509-22393-1-git-send-email-eranian@google.com> <1403193509-22393-2-git-send-email-eranian@google.com> <20140619180028.GU8178@tassilo.jf.intel.com> <20140619201801.GV8178@tassilo.jf.intel.com> <20140619204041.GW8178@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140619204041.GW8178@tassilo.jf.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 19, 2014 at 01:40:41PM -0700, Andi Kleen wrote: > On Thu, Jun 19, 2014 at 10:31:29PM +0200, Stephane Eranian wrote: > > On Thu, Jun 19, 2014 at 10:18 PM, Andi Kleen wrote: > > >> I don't quite understand that. > > >> You need to know which events support PEBS. You need a table > > > > > > We're talking about the kernel allowing things here. > > > Yes the user still needs to know what supports PEBS, but > > > that doesn't concern the kernel. > > > > > Just need to make sure you don't return bogus information. > > GIGO. We only need to prevent security issues. > Yes if the user specifies a bogus raw event it will not count. > That's fine. The important part is just that nothing ever crashes. Right. But IIRC you were previously arguing that we can in fact crash the machine with raw PEBS events, as illustrated with the SNB PEBS cycles 'event'. Which is where my strict_pebs patch came from; by default only allow the sanitized known-safe list of events, but allow the system administrator to disable that test and allow any PEBS event. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/