Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753794AbaFWJJh (ORCPT ); Mon, 23 Jun 2014 05:09:37 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:45184 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbaFWJJf (ORCPT ); Mon, 23 Jun 2014 05:09:35 -0400 Message-ID: <1403514536.4418.6.camel@jlt4.sipsolutions.net> Subject: Re: [PATCH 2/2] cfg80211: Use 5MHz bandwidth by default when checking usable channels From: Johannes Berg To: Felix Fietkau Cc: Rostislav Lisovy , "John W. Linville" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Sojka , s.sander@nordsys.de, jan-niklas.meier@volkswagen.de, Rostislav Lisovy Date: Mon, 23 Jun 2014 11:08:56 +0200 In-Reply-To: <53A6C0FF.9090104@openwrt.org> References: <1397565476-4348-1-git-send-email-rostislav.lisovy@fel.cvut.cz> <1397565476-4348-3-git-send-email-rostislav.lisovy@fel.cvut.cz> <53A6C0FF.9090104@openwrt.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2014-06-22 at 13:41 +0200, Felix Fietkau wrote: > On 2014-04-15 14:37, Rostislav Lisovy wrote: > > Current code checks if the 20MHz bandwidth is allowed for > > particular channel -- if it is not, the channel is disabled. > > Since we need to use 5/10 MHz channels, this code is modified in > > the way that the default bandwidth to check is 5MHz. If the > > maximum bandwidth allowed by the channel is smaller than 5MHz, > > the channel is disabled. Otherwise the channel is used and the > > flags are set according to the bandwidth allowed by the channel. > > > > Signed-off-by: Rostislav Lisovy > This change causes a regression and needs to be reverted or fixed. Noted, I've reverted it in mac80211.git. > It leaves Channel 12 enabled for US regdomain and does not prevent > bringing up AP mode on it (IEEE80211_CHAN_NO_20MHZ does not get set). I'm not sure this makes sense - CHAN_NO_20MHZ shouldn't get set on that channel? It should be disabled for other reasons for AP mode - e.g. NO_IR. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/