Message-ID: <1403531657.18747.53.camel@joe-AO725>
Subject: Re: [PATCH] staging: lirc: fix coding style problems
From: Joe Perches <joe@perches.com>
To: Raphael Poggi <poggi.raph@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Date: Mon, 23 Jun 2014 06:54:17 -0700
In-Reply-To: <1403530859-3341-1-git-send-email-poggi.raph@gmail.com>
References: <1403530859-3341-1-git-send-email-poggi.raph@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-06-23 at 15:40 +0200, Raphael Poggi wrote:
> This patch fix some coding style problems.
[]
> diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
[]
> @@ -626,8 +623,8 @@ static void imon_incoming_packet(struct imon_context *context,
>  	if (debug) {
>  		dev_info(dev, "raw packet: ");
>  		for (i = 0; i < len; ++i)
> -			printk("%02x ", buf[i]);
> -		printk("\n");
> +			dev_dbg(dev, "%02x ", buf[i]);
> +		dev_dbg(dev, "\n");

This chunk is not correct and causes output problems.

These printks should either use pr_cont or
you want to use something like print_hex_dump


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/