Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754262AbaFWOKj (ORCPT ); Mon, 23 Jun 2014 10:10:39 -0400 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:39028 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753482AbaFWOKi (ORCPT ); Mon, 23 Jun 2014 10:10:38 -0400 Date: Mon, 23 Jun 2014 15:10:23 +0100 From: Russell King - ARM Linux To: Pawel Moll Cc: Peter Maydell , Rob Herring , Mark Rutland , Ian Campbell , Kumar Gala , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , "devicetree@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , lkml - Kernel Mailing List , arm-mail-list Subject: Re: [PATCH v7 1/2] video: ARM CLCD: Add DT support Message-ID: <20140623141022.GJ32514@n2100.arm.linux.org.uk> References: <1403018494-10264-1-git-send-email-pawel.moll@arm.com> <1403531535.3804.11.camel@hornet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403531535.3804.11.camel@hornet> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 23, 2014 at 02:52:15PM +0100, Pawel Moll wrote: > On Fri, 2014-06-20 at 23:27 +0100, Peter Maydell wrote: > > How does this work for boards like the versatilepb which have a > > mux between a PL110 and the TFT, allowing it to efffectively > > rewire the pads at runtime under control of the SYS_CLCD > > sysreg (to give a wider range of colour modes than the > > PL110 supports natively)? > > The particular case you're referring has been already discussed several > times, and the bottom line here is that it's not PL111 compatible (there > are more changes than just the mux) and will need separate "compatible" > value and some tweaks in the driver (in the places currently doing > CONFIG_ARCH_VERSATILE). > > Now, if it was PL111 with an external, independent muxer, the pads > description would still hold its value (PL111's R would still be wired > up at a particular pad etc.) and the display pipeline drivers would have > to handle the case. Err. Somehow, I don't think you understand the hardware you're messing with there. Remember, I wrote support all the support code for the PL11x and supporting this. Yes, the Versatile PL110 has one difference: it has the IENB and CNTL registers swapped compared to the conventional PL110 devices. This can be handled via an appropriate compatible property. The hardware cursor registers are also omitted, but that's irrelevant as we don't use that. Other than that, it's a standard PL110. Connected to its outputs is a PLD. Inside the PLD is a mux controlled via the SYS_CLCD register. As far as the CLD outputs are concerned, they are standard. The PLD on their outputs routes the CLD bits to the 8-bit red, green and blue channels according to the configuration of SYS_CLCD to achieve the various colour formats which the CLCD does not natively provide for. So, it /is/ a PL110 with an independent external muxer. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/