Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753844AbaFXOPk (ORCPT ); Tue, 24 Jun 2014 10:15:40 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:51734 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753728AbaFXOPi (ORCPT ); Tue, 24 Jun 2014 10:15:38 -0400 Date: Tue, 24 Jun 2014 10:15:37 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Paul Bolle cc: Greg Kroah-Hartman , , , Subject: Re: [PATCH] Documentation: sysfs-bus-usb: update power/persist description In-Reply-To: <1403602404.1960.7.camel@x220> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jun 2014, Paul Bolle wrote: > There's no power/persist file for hubs. And CONFIG_USB_PERSIST was > removed in v2.6.26. Update the description of power/persist accordingly. > > Signed-off-by: Paul Bolle > --- > I don't know anything about USB-Persist. Could Greg and Alan please > check whether the new description does actually match reality? Not exactly. More details below. > Documentation/ABI/stable/sysfs-bus-usb | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/Documentation/ABI/stable/sysfs-bus-usb b/Documentation/ABI/stable/sysfs-bus-usb > index a6b685724740..a61d04b8fc78 100644 > --- a/Documentation/ABI/stable/sysfs-bus-usb > +++ b/Documentation/ABI/stable/sysfs-bus-usb > @@ -3,13 +3,13 @@ Date: May 2007 > KernelVersion: 2.6.23 > Contact: Alan Stern > Description: > - If CONFIG_USB_PERSIST is set, then each USB device directory > - will contain a file named power/persist. The file holds a > - boolean value (0 or 1) indicating whether or not the > - "USB-Persist" facility is enabled for the device. Since the > - facility is inherently dangerous, it is disabled by default > - for all devices except hubs. For more information, see > - Documentation/usb/persist.txt. > + USB device directories for all devices except hubs will contain > + a file named power/persist. The file holds a boolean value (0 > + or 1) indicating whether or not the "USB-Persist" facility is > + enabled for the device. Since the facility is inherently > + dangerous, it is disabled by default. For hubs this facility is > + always enabled making the file pointless. For more information, > + see Documentation/usb/persist.txt. Instead of depending on CONFIG_USB_PERSIST, the power/persist attribute depends on CONFIG_PM. But pointing that out would be redundant, since the power/ device directory itself doesn't exist unless CONFIG_PM is enabled. The default value for the persist facility depends on the setting of CONFIG_USB_DEFAULT_PERSIST. If that symbol is set then persist is enabled by default for all devices, except those which have the USB_QUIRK_RESET flag set (meaning that they will morph or change modes when reset). If the symbol is not set then persist is enabled by default only for hubs. Thanks for the documentation update. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/