Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965369AbaFXQrU (ORCPT ); Tue, 24 Jun 2014 12:47:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58101 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932385AbaFXQrS (ORCPT ); Tue, 24 Jun 2014 12:47:18 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <1400838223-30844-1-git-send-email-miklos@szeredi.hu> <28592.1401382081@warthog.procyon.org.uk> <11446.1401420931@jrobl> <7184.1401439773@warthog.procyon.org.uk> <15839.1401786056@warthog.procyon.org.uk> <10013.1401791634@warthog.procyon.org.uk> <20140603132153.GA26512@tucsk.piliscsaba.szeredi.hu> <19281.1401809418@warthog.procyon.org.uk> To: Miklos Szeredi Cc: dhowells@redhat.com, Sedat Dilek , "J. R. Okajima" , Al Viro , Linus Torvalds , linux-fsdevel , LKML , Christoph Hellwig , Andrew Morton , Robo Bot , Felix Fietkau , Neil Brown , Jordi Pujol , ezk@fsl.cs.sunysb.edu, "mszeredi@suse.cz" Subject: Overlayfs rename bug Date: Tue, 24 Jun 2014 17:46:14 +0100 Message-ID: <17091.1403628374@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > > Tentative Tested-by from me unless I can break it. > > Thanks for testing. Tested-by retracted temporarily. There's a bug in rename handling. If you clone: http://git.infradead.org/users/dhowells/unionmount-testsuite.git and check out the switch-to-python branch and do: ./run --no rename-mass then this works with no unioning used, but if you do: ./run --ov rename-mass to run it on overlayfs, then the following occurs: [root@andromeda union-testsuite]# ./run --ov rename-mass *** *** ./run --ov --ts=0 rename-mass *** TEST rename-mass.py:15: Mass rename sequential files into each other's vacated name slots ./run --rename /mnt/a/foo103 /mnt/a/foo104 ./run --rename /mnt/a/foo102 /mnt/a/foo103 ./run --rename /mnt/a/foo101 /mnt/a/foo102 ./run --rename /mnt/a/foo100 /mnt/a/foo101 ./run --rename /mnt/a/foo104 /mnt/a/foo105 /mnt/a/foo104: File unexpectedly found strace shows: rename("/mnt/a/foo104", "/mnt/a/foo105") = 0 lstat("/mnt/a/foo104", {st_mode=S_IFREG|0644, st_size=12, ...}) = 0 which shouldn't happen. The kernel is 17eb601eb5dbc8a2e200872380c03400813d4f1a from overlayfs.v22. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/