Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932878AbaFXQyE (ORCPT ); Tue, 24 Jun 2014 12:54:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60771 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754829AbaFXPvb (ORCPT ); Tue, 24 Jun 2014 11:51:31 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michal Schmidt , "David S. Miller" Subject: [PATCH 3.4 09/26] netlink: rate-limit leftover bytes warning and print process name Date: Tue, 24 Jun 2014 11:50:32 -0400 Message-Id: <20140624154619.941227265@linuxfoundation.org> X-Mailer: git-send-email 2.0.0 In-Reply-To: <20140624154619.499002156@linuxfoundation.org> References: <20140624154619.499002156@linuxfoundation.org> User-Agent: quilt/0.63-1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Michal Schmidt [ Upstream commit bfc5184b69cf9eeb286137640351c650c27f118a ] Any process is able to send netlink messages with leftover bytes. Make the warning rate-limited to prevent too much log spam. The warning is supposed to help find userspace bugs, so print the triggering command name to implicate the buggy program. [v2: Use pr_warn_ratelimited instead of printk_ratelimited.] Signed-off-by: Michal Schmidt Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- lib/nlattr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/lib/nlattr.c +++ b/lib/nlattr.c @@ -13,6 +13,7 @@ #include #include #include +#include #include static const u16 nla_attr_minlen[NLA_TYPE_MAX+1] = { @@ -197,8 +198,8 @@ int nla_parse(struct nlattr **tb, int ma } if (unlikely(rem > 0)) - printk(KERN_WARNING "netlink: %d bytes leftover after parsing " - "attributes.\n", rem); + pr_warn_ratelimited("netlink: %d bytes leftover after parsing attributes in process `%s'.\n", + rem, current->comm); err = 0; errout: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/