Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754910AbaFXSjV (ORCPT ); Tue, 24 Jun 2014 14:39:21 -0400 Received: from kanga.kvack.org ([205.233.56.17]:35247 "EHLO kanga.kvack.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbaFXSjT (ORCPT ); Tue, 24 Jun 2014 14:39:19 -0400 Date: Tue, 24 Jun 2014 14:39:18 -0400 From: Benjamin LaHaise To: Jeff Moyer Cc: Linus Torvalds , security@kernel.org, linux-aio@kvack.org, linux-kernel@vger.kernel.org, Mateusz Guzik , Petr Matousek , Kent Overstreet , stable@vger.kernel.org Subject: Re: [PATCH 2/2] aio: fix kernel memory disclosure in io_getevents() introduced in v3.10 Message-ID: <20140624183918.GM23137@kvack.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 24, 2014 at 02:23:20PM -0400, Jeff Moyer wrote: > Benjamin LaHaise writes: > > > A kernel memory disclosure was introduced in aio_read_events_ring() in v3.10 > > by commit a31ad380bed817aa25f8830ad23e1a0480fef797. The changes made to > > aio_read_events_ring() failed to correctly limit the index into > > ctx->ring_pages[], allowing an attacked to cause the subsequent kmap() of > > an arbitrary page with a copy_to_user() to copy the contents into userspace. > > This vulnerability has been assigned CVE-2014-0206. Thanks to Mateusz and > > Petr for disclosing this issue. > > > > This patch applies to v3.12+. A separate backport is needed for 3.10/3.11. > > Note that a 3.10 backport will need to remove this line from free_ioctx > as well: > atomic_sub(avail, &ctx->reqs_active); > > Reviewed-by: Jeff Moyer Can you post the backport for 3.10 so the -stable folks have something they can use that was tested? Cheers, -ben -- "Thought is the essence of where you are now." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/