Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754735AbaFXTlO (ORCPT ); Tue, 24 Jun 2014 15:41:14 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:41169 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbaFXTlM (ORCPT ); Tue, 24 Jun 2014 15:41:12 -0400 MIME-Version: 1.0 In-Reply-To: <53A9C6EB.50900@zytor.com> References: <2a5bebff42defd8a5e81d96f7dc00f21143c80e8.1403129369.git.luto@amacapital.net> <20140622084754.GA15094@gmail.com> <53A9C2C3.7050508@zytor.com> <53A9C6EB.50900@zytor.com> From: Andy Lutomirski Date: Tue, 24 Jun 2014 12:40:51 -0700 Message-ID: Subject: Re: [tip:x86/urgent] x86/vdso: Discard the __bug_table section To: "H. Peter Anvin" Cc: Ingo Molnar , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "H. Peter Anvin" , "linux-tip-commits@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 24, 2014 at 11:43 AM, H. Peter Anvin wrote: > On 06/24/2014 11:37 AM, Andy Lutomirski wrote: >>> >>> diff --git a/arch/x86/vdso/vdso2c.h b/arch/x86/vdso/vdso2c.h >>> index f42e2ddc663d..94158e100f26 100644 >>> --- a/arch/x86/vdso/vdso2c.h >>> +++ b/arch/x86/vdso/vdso2c.h >>> @@ -99,8 +99,9 @@ static void BITSFUNC(copy_section)(struct >>> BITSFUNC(fake_sections) *out, >>> if (!copy) >>> return; >>> >>> - if (out->count >= out->max_count) >>> - fail("too many copied sections (max = %d)\n", >>> out->max_count); >>> + if (out->count > out->max_count) >>> + fail("too many copied sections (max = %d, need = %d)\n", >>> + out->max_count, out->count); >>> >> >> I think the old test was correct: we haven't incremented count yet >> (it's a couple lines below), so count is the zero-based index to which >> we're writing. >> >> I thought of doing the need = %d thing, but I think that the output is >> a foregone conclusion: count == max_count + 1 when this fails. A list >> of all the section names would be more interesting, but eu-readelf -S >> will tell is that. >> > > Well, I have reproduced this failure. eu-readelf output included. It's branch profiling. Patches coming. > > -hpa > -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/