Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 20 Nov 2002 19:32:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 20 Nov 2002 19:32:34 -0500 Received: from leibniz.math.psu.edu ([146.186.130.2]:6335 "EHLO math.psu.edu") by vger.kernel.org with ESMTP id ; Wed, 20 Nov 2002 19:32:32 -0500 Date: Wed, 20 Nov 2002 19:39:35 -0500 (EST) From: Alexander Viro To: Andries.Brouwer@cwi.nl cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com Subject: Re: kill i_dev In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 22 On Thu, 21 Nov 2002 Andries.Brouwer@cwi.nl wrote: > One disadvantage of enlarging the size of dev_t is > that struct inode grows. Bad. > We used to have i_dev and i_rdev; today i_rdev has split into > i_rdev, i_bdev and i_cdev. Bad. > > It looks like these four fields can be replaced by a single one, > making struct inode smaller. Not bad. No, they can't. We _can_ put i_bdev/i_cdev into union and we can kill i_dev. However, rdev and [cb]dev will have to remain separate. BTW, watch out for socket.c use of ->i_dev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/