Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753564AbaFXW7V (ORCPT ); Tue, 24 Jun 2014 18:59:21 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:56919 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752256AbaFXW7S (ORCPT ); Tue, 24 Jun 2014 18:59:18 -0400 MIME-Version: 1.0 In-Reply-To: References: <1402464739-19044-1-git-send-email-tushar.b@samsung.com> <1402464739-19044-2-git-send-email-tushar.b@samsung.com> <7ha99jjspt.fsf@paris.lan> Date: Tue, 24 Jun 2014 15:59:17 -0700 Message-ID: Subject: Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled From: Doug Anderson To: Tushar Behera Cc: Kevin Hilman , lkml , ML Devicetree , linux-samsung-soc , ML Arch-Arm , Mike Turquette , Tomasz Figa , Russell King , Kumar Gala , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring , Kukjin Kim , Shaik Ameer Basha Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tushar, On Thu, Jun 12, 2014 at 12:40 AM, Tushar Behera wrote: > On Wed, Jun 11, 2014 at 10:20 PM, Kevin Hilman wrote: >> Tushar Behera writes: >> >>> When the output clock of AUDSS mux is disabled, we are getting kernel >>> oops while doing a clk_get() on other clocks provided by AUDSS. >>> >>> Though user manual doesn't specify this dependency, we came across >>> this issue while disabling the parent of AUDSS mux clocks. >>> >>> Keeping the parents of AUDSS mux always enabled fixes this issue. >> >> While this patch works (and fixes the boot problem for me), it seems >> like it's papering over the real problem. >> > > Thanks for testing. > >> Seems like the right fix is actually modelling the clocks properly so >> that enabling a child clock ensures that the parent is also enabled. >> > > Patch 2/3 was to ensure we have proper clock tree defined for > Exynos5420. While testing with audio disabled, that patch alone fixed > the issue. But when audio was enabled (and hence I2S0 was trying to > access the clocks), we got some kernel oops during late booting, hence > I came up this solution. > > The solution might be a little half-baked because of the urgency to > push the fix, but will try to dig more into the issue on Monday when I > resume office. Which Monday were you referring to? ;) ...but in all seriousness do you have an official status update on this patch? It seems as if it's not needed and all you need is , but it would be nice to get an official confirmation. Thanks! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/