Message-id: <53AA613C.4060807@samsung.com>
Date: Wed, 25 Jun 2014 07:42:20 +0200
From: Marek Szyprowski <m.szyprowski@samsung.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101
 Thunderbird/24.6.0
MIME-version: 1.0
To: Kamil Debski <k.debski@samsung.com>, "'Daniel Drake'" <drake@endlessm.com>
Cc: linux-kernel@vger.kernel.org,
        "'linux-samsung-soc'" <linux-samsung-soc@vger.kernel.org>,
        linux-usb@vger.kernel.org, kishon@ti.com,
        Tomasz Figa <t.figa@samsung.com>, gautam.vivek@samsung.com
Subject: Re: [PATCH] phy: phy-samsung-usb2: Change phy power on/power off
 sequence
References: <1403614495-9291-1-git-send-email-k.debski@samsung.com>
 <CAD8Lp441832-ZVV8FQChEXcLqVpZqygv3iaF95_SfZOH_xkFPg@mail.gmail.com>
 <074a01cf8fc1$e906f0c0$bb14d240$%debski@samsung.com>
In-reply-to: <074a01cf8fc1$e906f0c0$bb14d240$%debski@samsung.com>
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Hello,

On 2014-06-24 17:35, Kamil Debski wrote:
> On Tue, Jun 24, 2014 at 1:54 PM, Kamil Debski <k.debski@samsung.com> 
> wrote:
>>> The Exynos4412 USB 2.0 PHY hardware differs from the description
>>> provided in the documentation. Some register bits have different
>>> function. This patch fixes the defines of register bits and changes
>>> the way how phys are powered on and off.
>> I guess this replaces the patch titled "drivers: phy: exynos4x12-phy:
>> fix HSIC1 power on/off sequence"
> Yes, indeed it replaces this patch. I did some more research on how the
> hardware actually behaves.

My patch was a quick hack to get HSIC1 working. Kamil spent much more time
trying to figure out how the hardware actually behaves. Please drop my patch
and replace it with this one.

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

>
>> Tested on ODROID-U2. Seems to be working as well as the previous patch:
> Thank you very much for testing.
>
>> - Internal SMSC hub works on boot and after reboot, tested with USB
>> mouse
>> - Internal SMSC ethernet device works on boot, but disappears upon
>> reboot. (same as previous patch, also reproduced by Marek)
> By reboot I guess that you mean typing "reboot" or by using SysRq magic
> and not power cycling?
>
> If so, I had experienced the same symptoms. I guess that the Ethernet
> chip is not reset properly and fails to enumerate without power cycling
> (it's nRESET pin is connected to P3V3).
>
> I found that removing regulator-always-on from buck8_reg: BUCK8 in the
> dts file fixes this problem.

Thanks for investigating this issue! I will add this fix to next version
of Odroid patches.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/