Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754634AbaFYJhO (ORCPT ); Wed, 25 Jun 2014 05:37:14 -0400 Received: from casper.infradead.org ([85.118.1.10]:57378 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753734AbaFYJhL (ORCPT ); Wed, 25 Jun 2014 05:37:11 -0400 Date: Wed, 25 Jun 2014 11:36:57 +0200 From: Peter Zijlstra To: "Srivatsa S. Bhat" Cc: Stephen Warren , Frederic Weisbecker , LKML , Andrew Morton , Eric Dumazet , Ingo Molnar , Kevin Hilman , "Paul E. McKenney" , Thomas Gleixner , Viresh Kumar , "linux-next@vger.kernel.org" Subject: Re: [PATCH 2/6] irq_work: Implement remote queueing Message-ID: <20140625093657.GN19860@laptop.programming.kicks-ass.net> References: <1402413309-3415-1-git-send-email-fweisbec@gmail.com> <1402413309-3415-3-git-send-email-fweisbec@gmail.com> <53A9E0A5.5040402@wwwdotorg.org> <20140625051234.GD6758@twins.programming.kicks-ass.net> <20140625051721.GG3588@twins.programming.kicks-ass.net> <53AA6E11.1000404@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53AA6E11.1000404@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 25, 2014 at 12:07:05PM +0530, Srivatsa S. Bhat wrote: > I don't think irqs_disabled() is the problematic condition, since > hotplug_cfg() invokes irq_work_run() from CPU_DYING context (which has > irqs disabled). I guess you meant to remove the in_irq() check inside > irq_work_run() instead? Yes, clearly I should not get up at 6am.. :-) Let me go do a new one. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/