Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755368AbaFYJi1 (ORCPT ); Wed, 25 Jun 2014 05:38:27 -0400 Received: from mx0.aculab.com ([213.249.233.131]:51821 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754007AbaFYJi0 convert rfc822-to-8bit (ORCPT ); Wed, 25 Jun 2014 05:38:26 -0400 From: David Laight To: "'Chen, Alvin'" , Greg Kroah-Hartman CC: Alan Stern , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Ong, Boon Leong" Subject: RE: [PATCH] USB: ehci-pci: USB host controller support for Intel Quark X1000 Thread-Topic: [PATCH] USB: ehci-pci: USB host controller support for Intel Quark X1000 Thread-Index: AQHPj6/C5BxdJArRXUevrLYTW6T4oZuBj0uwgAAC7LA= Date: Wed, 25 Jun 2014 09:37:45 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D17264B1D@AcuExch.aculab.com> References: <1403625103-28078-1-git-send-email-alvin.chen@intel.com> <1403625103-28078-2-git-send-email-alvin.chen@intel.com> <20140624132527.GB1215@kroah.com> <4656BEB6164FC34F8171C6538F1A595B2E946EF1@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <4656BEB6164FC34F8171C6538F1A595B2E946EF1@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chen, Alvin > > On Tue, Jun 24, 2014 at 08:51:43AM -0700, Chen, Alvin wrote: > > > diff --git a/drivers/usb/host/pci-quirks.c > > > b/drivers/usb/host/pci-quirks.c index 00661d3..1ea8803 100644 > > > --- a/drivers/usb/host/pci-quirks.c > > > +++ b/drivers/usb/host/pci-quirks.c > > > @@ -823,6 +823,48 @@ static int handshake(void __iomem *ptr, u32 mask, > > u32 done, > > > return -ETIMEDOUT; > > > } > > > > > > +#define PCI_DEVICE_ID_INTEL_QUARK_X1000_SOC 0x0939 > > > +bool usb_is_intel_qrk(struct pci_dev *pdev) { > > > + return pdev->vendor == PCI_VENDOR_ID_INTEL && > > > + pdev->device == PCI_DEVICE_ID_INTEL_QUARK_X1000_SOC; > > > + > > > +} > > > +EXPORT_SYMBOL_GPL(usb_is_intel_qrk); > > > > There is no lack of vowels available to you, please use them. > > > > OK, I will change ' usb_is_intel_qrk ' to ' usb_is_intel_quark'. Or even usb_is_intel_quark_x1000() ? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/