Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756654AbaFYNIz (ORCPT ); Wed, 25 Jun 2014 09:08:55 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:25444 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754085AbaFYNIx (ORCPT ); Wed, 25 Jun 2014 09:08:53 -0400 Message-ID: <53AAC9D8.4010204@huawei.com> Date: Wed, 25 Jun 2014 21:08:40 +0800 From: Liu hua User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: "Zhang, Yanmin" , "Luck, Tony" , "anton@enomsg.org" , "ccross@android.com" , "keescook@chromium.org" , "linux-kernel@vger.kernel.org" CC: Wang Nan , "peifeiyue@huawei.com" , Liu ShuoX Subject: Re: Should Pstore(ramoops) records customized information? References: <539E6D4D.5000802@huawei.com> <53A164DB.1020305@huawei.com> <3908561D78D1C84285E8C5FCA982C28F32838E10@ORSMSX114.amr.corp.intel.com> <53A2D5BB.5040500@huawei.com> <3908561D78D1C84285E8C5FCA982C28F3283A5E3@ORSMSX114.amr.corp.intel.com> <53A41125.4080802@huawei.com> <53AA1A9F.8030108@linux.intel.com> In-Reply-To: <53AA1A9F.8030108@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.111.58.238] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2014/6/25 8:41, Zhang, Yanmin 写道: > > On 2014/6/20 18:47, Liu hua wrote: >> On 2014/6/20 7:42, Luck, Tony wrote: >> >>>> BTW, I note that "extern struct pstore_info *psinfo" locates in >>>> fs/pstore/internal.h. So users out of directory "fs/pstore/" can not use pstore to >>>> record messages. We do not want other kernel users to use pstore, right? And can we >>>> break this? >>> Yes we can make some interface visible to the rest of the kernel ... probably >>> not the raw "*psinfo" though. Perhaps the pstore_alloc_ring_buffer() and >>> pstore_write_ring_buffer() functions should be the ones exported to the >>> rest of the kernel. >>> >>>> ditoo.. Since other backends like efi and erst may can not privide such ring buffer. >>>> So pstore_alloc_ring_buffer should be a funciton pointer of pstore_info struct. >>> Yes - that allows less capable backend like ERST and efivars to not provide the >>> service. Since it becomes internal, you can drop the "pstore_" prefix. E.g. >>> something like: >>> >>> int pstore_alloc_ring_buffer(char *name, int size) >>> { >>> return psinfo->alloc_ring_buffer(name, size); >>> } >>> EXPORT_SYMBOL_GPL(pstore_alloc_ring_buffer); >>> >>> ... and you have to find/make some global header for the "extern" declaration. >> I will make these RFC patch series according to our discussion. Thanks you very to >> valuable advice. > > Sorry for seeing your email late.We already worked out some patches to restructure > pstore. Would you like to try patchset http://article.gmane.org/gmane.linux.kernel/1697680/? > > We have more patches available to add some flags to disable/enable specific zones. That's great! I have tried your patches. BTW, Your patches do not work on ARM platform, before I changed linker scripts; And can we use this method in modules(I failed to do that)? After a quick glance and try, I think my idea is a little different from yours. I will reply you later. > Yanmin > > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/